Title: [200966] trunk/Source/WebKit2
- Revision
- 200966
- Author
- commit-qu...@webkit.org
- Date
- 2016-05-16 13:52:33 -0700 (Mon, 16 May 2016)
Log Message
[iOS] Remove dispatch_after in -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=157745
Patch by Chelsea Pugh <cp...@apple.com> on 2016-05-16
Reviewed by Dan Bernstein.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession setSuggestions:]): Remove the dispatch_after since
there is no longer a chance of keyboard suggestions replacing the
suggestions set here.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200965 => 200966)
--- trunk/Source/WebKit2/ChangeLog 2016-05-16 20:46:01 UTC (rev 200965)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-16 20:52:33 UTC (rev 200966)
@@ -1,3 +1,15 @@
+2016-05-16 Chelsea Pugh <cp...@apple.com>
+
+ [iOS] Remove dispatch_after in -[WKFormInputSession setSuggestions:]
+ https://bugs.webkit.org/show_bug.cgi?id=157745
+
+ Reviewed by Dan Bernstein.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKFormInputSession setSuggestions:]): Remove the dispatch_after since
+ there is no longer a chance of keyboard suggestions replacing the
+ suggestions set here.
+
2016-05-16 Brian Burg <bb...@apple.com>
Crash simulating keystrokes at WebKit::WebAutomationSession::platformSimulateKeyStroke
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (200965 => 200966)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2016-05-16 20:46:01 UTC (rev 200965)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2016-05-16 20:52:33 UTC (rev 200966)
@@ -346,11 +346,7 @@
#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
id <UITextInputSuggestionDelegate> suggestionDelegate = (id <UITextInputSuggestionDelegate>)_contentView.inputDelegate;
_suggestions = adoptNS([suggestions copy]);
- // FIXME 25102224: Remove this dispatch_after once race condition causing keyboard suggestions to overwrite
- // the suggestions being set is resolved
- dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(20 * NSEC_PER_MSEC)), dispatch_get_main_queue(), ^{
- [suggestionDelegate setSuggestions:suggestions];
- });
+ [suggestionDelegate setSuggestions:suggestions];
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
