Title: [201192] trunk/Source/WebInspectorUI
- Revision
- 201192
- Author
- nvasil...@apple.com
- Date
- 2016-05-19 15:27:17 -0700 (Thu, 19 May 2016)
Log Message
REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=157918
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
(WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
Set the initial value of _loadNodeAttributesTimeout to be 0,
as setTimeout always returns a positive integer.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201191 => 201192)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 22:25:13 UTC (rev 201191)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 22:27:17 UTC (rev 201192)
@@ -1,3 +1,17 @@
+2016-05-19 Nikita Vasilyev <nvasil...@apple.com>
+
+ REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=157918
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/DOMTreeManager.js:
+ (WebInspector.DOMTreeManager):
+ (WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
+ (WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
+ Set the initial value of _loadNodeAttributesTimeout to be 0,
+ as setTimeout always returns a positive integer.
+
2016-05-19 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Heap Snapshots taken before timeline view has a zero time do not get shown
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js (201191 => 201192)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js 2016-05-19 22:25:13 UTC (rev 201191)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js 2016-05-19 22:27:17 UTC (rev 201192)
@@ -42,6 +42,7 @@
this._flows = new Map;
this._contentNodesToFlowsMap = new Map;
this._restoreSelectedNodeIsAllowed = true;
+ this._loadNodeAttributesTimeout = 0;
WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
}
@@ -150,7 +151,7 @@
{
for (var nodeId of nodeIds)
this._attributeLoadNodeIds[nodeId] = true;
- if ("_loadNodeAttributesTimeout" in this)
+ if (this._loadNodeAttributesTimeout)
return;
this._loadNodeAttributesTimeout = setTimeout(this._loadNodeAttributes.bind(this), 0);
}
@@ -171,7 +172,7 @@
}
}
- this._loadNodeAttributesTimeout = undefined;
+ this._loadNodeAttributesTimeout = 0;
for (var nodeId in this._attributeLoadNodeIds) {
var nodeIdAsNumber = parseInt(nodeId);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
