Title: [201656] trunk/Source/_javascript_Core
- Revision
- 201656
- Author
- benja...@webkit.org
- Date
- 2016-06-03 14:13:34 -0700 (Fri, 03 Jun 2016)
Log Message
Fix some more INFINITI->INFINITY typos
Unreviewed.
The tests were not covering the edge cases they were supposed to test.
Patch by Benjamin Poulain <bpoul...@apple.com> on 2016-06-03
* tests/stress/math-ceil-basics.js:
(testMathCeilOnConstants):
* tests/stress/math-clz32-basics.js:
(testMathClz32OnDoubles):
(testMathClz32OnConstants):
* tests/stress/math-floor-basics.js:
(testMathFloorOnConstants):
* tests/stress/math-round-basics.js:
(testMathRoundOnConstants):
* tests/stress/math-trunc-basics.js:
(testMathTruncOnConstants):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (201655 => 201656)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-03 21:13:34 UTC (rev 201656)
@@ -1,3 +1,23 @@
+2016-06-03 Benjamin Poulain <bpoul...@apple.com>
+
+ Fix some more INFINITI->INFINITY typos
+
+ Unreviewed.
+
+ The tests were not covering the edge cases they were supposed to test.
+
+ * tests/stress/math-ceil-basics.js:
+ (testMathCeilOnConstants):
+ * tests/stress/math-clz32-basics.js:
+ (testMathClz32OnDoubles):
+ (testMathClz32OnConstants):
+ * tests/stress/math-floor-basics.js:
+ (testMathFloorOnConstants):
+ * tests/stress/math-round-basics.js:
+ (testMathRoundOnConstants):
+ * tests/stress/math-trunc-basics.js:
+ (testMathTruncOnConstants):
+
2016-06-02 Gavin & Ellie Barraclough <barraclo...@apple.com>
JSGlobalObject::addFunction should call deleteProperty rather than removeDirect
Modified: trunk/Source/_javascript_Core/tests/stress/math-ceil-basics.js (201655 => 201656)
--- trunk/Source/_javascript_Core/tests/stress/math-ceil-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/tests/stress/math-ceil-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
@@ -220,12 +220,12 @@
var value = Math.ceil(NaN);
if (value === value)
throw new Error("Math.ceil(NaN) = " + value);
- var value = Math.ceil(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.ceil(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.ceil(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.ceil(Number.NEGATIVE_INFINITI) = " + value);
+ var value = Math.ceil(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.ceil(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.ceil(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.ceil(Number.NEGATIVE_INFINITY) = " + value);
var value = Math.ceil(Math.E);
if (value !== 3)
throw new Error("Math.ceil(Math.E) = " + value);
Modified: trunk/Source/_javascript_Core/tests/stress/math-clz32-basics.js (201655 => 201656)
--- trunk/Source/_javascript_Core/tests/stress/math-clz32-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/tests/stress/math-clz32-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
@@ -95,13 +95,13 @@
if (value != 32)
throw "mathClz32OnDouble(NaN) = " + value;
- var value = mathClz32OnDouble(Number.POSITIVE_INFINITI);
+ var value = mathClz32OnDouble(Number.POSITIVE_INFINITY);
if (value != 32)
- throw "mathClz32OnDouble(Number.POSITIVE_INFINITI) = " + value;
+ throw "mathClz32OnDouble(Number.POSITIVE_INFINITY) = " + value;
- var value = mathClz32OnDouble(Number.NEGATIVE_INFINITI);
+ var value = mathClz32OnDouble(Number.NEGATIVE_INFINITY);
if (value != 32)
- throw "mathClz32OnDouble(Number.NEGATIVE_INFINITI) = " + value;
+ throw "mathClz32OnDouble(Number.NEGATIVE_INFINITY) = " + value;
}
noInline(testMathClz32OnDoubles);
@@ -185,12 +185,12 @@
var value = Math.clz32(NaN);
if (value !== 32)
throw "Math.clz32(NaN) = " + value;
- var value = Math.clz32(Number.POSITIVE_INFINITI);
+ var value = Math.clz32(Number.POSITIVE_INFINITY);
if (value !== 32)
- throw "Math.clz32(Number.POSITIVE_INFINITI) = " + value;
- var value = Math.clz32(Number.NEGATIVE_INFINITI);
+ throw "Math.clz32(Number.POSITIVE_INFINITY) = " + value;
+ var value = Math.clz32(Number.NEGATIVE_INFINITY);
if (value !== 32)
- throw "Math.clz32(Number.NEGATIVE_INFINITI) = " + value;
+ throw "Math.clz32(Number.NEGATIVE_INFINITY) = " + value;
var value = Math.clz32(Math.E);
if (value !== 30)
throw "Math.clz32(Math.E) = " + value;
Modified: trunk/Source/_javascript_Core/tests/stress/math-floor-basics.js (201655 => 201656)
--- trunk/Source/_javascript_Core/tests/stress/math-floor-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/tests/stress/math-floor-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
@@ -220,12 +220,12 @@
var value = Math.floor(NaN);
if (value === value)
throw new Error("Math.floor(NaN) = " + value);
- var value = Math.floor(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.floor(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.floor(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.floor(Number.NEGATIVE_INFINITI) = " + value);
+ var value = Math.floor(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.floor(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.floor(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.floor(Number.NEGATIVE_INFINITY) = " + value);
var value = Math.floor(Math.E);
if (value !== 2)
throw new Error("Math.floor(Math.E) = " + value);
Modified: trunk/Source/_javascript_Core/tests/stress/math-round-basics.js (201655 => 201656)
--- trunk/Source/_javascript_Core/tests/stress/math-round-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/tests/stress/math-round-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
@@ -220,12 +220,12 @@
var value = Math.round(NaN);
if (value === value)
throw "Math.round(NaN) = " + value;
- var value = Math.round(Number.POSITIVE_INFINITI);
- if (value === value)
- throw "Math.round(Number.POSITIVE_INFINITI) = " + value;
- var value = Math.round(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw "Math.round(Number.NEGATIVE_INFINITI) = " + value;
+ var value = Math.round(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw "Math.round(Number.POSITIVE_INFINITY) = " + value;
+ var value = Math.round(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw "Math.round(Number.NEGATIVE_INFINITY) = " + value;
var value = Math.round(Math.E);
if (value !== 3)
throw "Math.round(Math.E) = " + value;
Modified: trunk/Source/_javascript_Core/tests/stress/math-trunc-basics.js (201655 => 201656)
--- trunk/Source/_javascript_Core/tests/stress/math-trunc-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/_javascript_Core/tests/stress/math-trunc-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
@@ -219,12 +219,12 @@
var value = Math.trunc(NaN);
if (value === value)
throw new Error("Math.trunc(NaN) = " + value);
- var value = Math.trunc(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.trunc(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.trunc(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.trunc(Number.NEGATIVE_INFINITI) = " + value);
+ var value = Math.trunc(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.trunc(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.trunc(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.trunc(Number.NEGATIVE_INFINITY) = " + value);
var value = Math.trunc(Math.E);
if (value !== 2)
throw new Error("Math.trunc(Math.E) = " + value);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
