Title: [201670] trunk/Source/_javascript_Core
- Revision
- 201670
- Author
- sbar...@apple.com
- Date
- 2016-06-03 16:51:25 -0700 (Fri, 03 Jun 2016)
Log Message
Some shadow chicken code is wrong when run on a big endian CPU
https://bugs.webkit.org/show_bug.cgi?id=158361
Reviewed by Mark Lam.
This code was wrong on a big endian CPU, and it was
also an anti-pattern in the file. The code was harmless
on a little endian CPU, but it's better to remove it.
* llint/LowLevelInterpreter64.asm:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (201669 => 201670)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-03 23:27:11 UTC (rev 201669)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-03 23:51:25 UTC (rev 201670)
@@ -1,3 +1,16 @@
+2016-06-03 Saam barati <sbar...@apple.com>
+
+ Some shadow chicken code is wrong when run on a big endian CPU
+ https://bugs.webkit.org/show_bug.cgi?id=158361
+
+ Reviewed by Mark Lam.
+
+ This code was wrong on a big endian CPU, and it was
+ also an anti-pattern in the file. The code was harmless
+ on a little endian CPU, but it's better to remove it.
+
+ * llint/LowLevelInterpreter64.asm:
+
2016-06-03 Keith Miller <keith_mil...@apple.com>
Add argument_count bytecode for concat
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (201669 => 201670)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2016-06-03 23:27:11 UTC (rev 201669)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2016-06-03 23:51:25 UTC (rev 201670)
@@ -2440,7 +2440,7 @@
storep cfr, ShadowChicken::Packet::frame[t0]
loadp CallerFrame[cfr], t1
storep t1, ShadowChicken::Packet::callerFrame[t0]
- loadp Callee + PayloadOffset[cfr], t1
+ loadp Callee[cfr], t1
storep t1, ShadowChicken::Packet::callee[t0]
loadVariable(1, t1)
storep t1, ShadowChicken::Packet::scope[t0]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
