Title: [201795] trunk/Tools
- Revision
- 201795
- Author
- carlo...@webkit.org
- Date
- 2016-06-07 23:49:36 -0700 (Tue, 07 Jun 2016)
Log Message
[GTK] Use a longer timeout for glib unit tests
https://bugs.webkit.org/show_bug.cgi?id=158476
Reviewed by Darin Adler.
The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
GLib tests.
* Scripts/run-gtk-tests:
(TestRunner._run_test_glib):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (201794 => 201795)
--- trunk/Tools/ChangeLog 2016-06-08 06:30:47 UTC (rev 201794)
+++ trunk/Tools/ChangeLog 2016-06-08 06:49:36 UTC (rev 201795)
@@ -1,3 +1,18 @@
+2016-06-07 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Use a longer timeout for glib unit tests
+ https://bugs.webkit.org/show_bug.cgi?id=158476
+
+ Reviewed by Darin Adler.
+
+ The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
+ same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
+ the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
+ GLib tests.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner._run_test_glib):
+
2016-06-07 Keith Rollin <krol...@apple.com>
Remove all uses of PassRefPtr in WTF
Modified: trunk/Tools/Scripts/run-gtk-tests (201794 => 201795)
--- trunk/Tools/Scripts/run-gtk-tests 2016-06-08 06:30:47 UTC (rev 201794)
+++ trunk/Tools/Scripts/run-gtk-tests 2016-06-08 06:49:36 UTC (rev 201795)
@@ -326,7 +326,11 @@
for test_case in self._test_cases_to_skip(test_program):
tester_command.extend(['-s', test_case])
tester_command.append(test_program)
- timeout = self._options.timeout
+ # This timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of
+ # the same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out
+ # in the bots because the timeout is not enough to run all the tests cases. So, we use a longer timeout for GLib
+ # tests (timeout * 2).
+ timeout = self._options.timeout * 2
test = os.path.join(os.path.basename(os.path.dirname(test_program)), os.path.basename(test_program))
if test in TestRunner.SLOW:
timeout *= 5
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
