Title: [202211] trunk/Source/WebCore
- Revision
- 202211
- Author
- youenn.fab...@crf.canon.fr
- Date
- 2016-06-19 10:51:51 -0700 (Sun, 19 Jun 2016)
Log Message
The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
https://bugs.webkit.org/show_bug.cgi?id=158834
Reviewed by Eric Carlson.
No change of behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Explicitly setting DOMWrapped type definition from
JSXX class deriving from another JSYY class.
* bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
* bindings/scripts/test/JS/JSTestNode.h: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202210 => 202211)
--- trunk/Source/WebCore/ChangeLog 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/ChangeLog 2016-06-19 17:51:51 UTC (rev 202211)
@@ -1,3 +1,18 @@
+2016-06-19 Youenn Fablet <youenn.fab...@crf.canon.fr>
+
+ The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
+ https://bugs.webkit.org/show_bug.cgi?id=158834
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader): Explicitly setting DOMWrapped type definition from
+ JSXX class deriving from another JSYY class.
+ * bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
+ * bindings/scripts/test/JS/JSTestNode.h: Ditto.
+
2016-06-18 Antti Koivisto <an...@apple.com>
Use time literals in WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-06-19 17:51:51 UTC (rev 202211)
@@ -1104,6 +1104,8 @@
# Static create methods
push(@headerContent, "public:\n");
push(@headerContent, " typedef $parentClassName Base;\n");
+ push(@headerContent, " typedef $implType DOMWrapped;\n") if $interface->parent;
+
if ($interfaceName eq "DOMWindow") {
push(@headerContent, " static $className* create(JSC::VM& vm, JSC::Structure* structure, Ref<$implType>&& impl, JSDOMWindowShell* windowShell)\n");
push(@headerContent, " {\n");
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2016-06-19 17:51:51 UTC (rev 202211)
@@ -28,6 +28,7 @@
class JSTestEventTarget : public JSEventTarget {
public:
typedef JSEventTarget Base;
+ typedef TestEventTarget DOMWrapped;
static JSTestEventTarget* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestEventTarget>&& impl)
{
globalObject->masqueradesAsUndefinedWatchpoint()->fireAll("Allocated masquerading object");
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h 2016-06-19 17:51:51 UTC (rev 202211)
@@ -28,6 +28,7 @@
class WEBCORE_TESTSUPPORT_EXPORT JSTestNode : public JSNode {
public:
typedef JSNode Base;
+ typedef TestNode DOMWrapped;
static JSTestNode* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestNode>&& impl)
{
JSTestNode* ptr = new (NotNull, JSC::allocateCell<JSTestNode>(globalObject->vm().heap)) JSTestNode(structure, *globalObject, WTFMove(impl));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
