Title: [202711] trunk/Source/WebInspectorUI
- Revision
- 202711
- Author
- bb...@apple.com
- Date
- 2016-06-30 15:14:20 -0700 (Thu, 30 Jun 2016)
Log Message
Web Inspector: the last normal tab cannot be closed with "Close Tab" context menu item
https://bugs.webkit.org/show_bug.cgi?id=159317
<rdar://problem/27042491>
Reviewed by Timothy Hatcher.
* UserInterface/Views/TabBarItem.js:
(WebInspector.TabBarItem.prototype._handleContextMenuEvent):
(WebInspector.TabBarItem): fix the _expression_ that controls whether the item is disabled.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (202710 => 202711)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-06-30 22:06:44 UTC (rev 202710)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-30 22:14:20 UTC (rev 202711)
@@ -1,3 +1,15 @@
+2016-06-30 Brian Burg <bb...@apple.com>
+
+ Web Inspector: the last normal tab cannot be closed with "Close Tab" context menu item
+ https://bugs.webkit.org/show_bug.cgi?id=159317
+ <rdar://problem/27042491>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TabBarItem.js:
+ (WebInspector.TabBarItem.prototype._handleContextMenuEvent):
+ (WebInspector.TabBarItem): fix the _expression_ that controls whether the item is disabled.
+
2016-06-30 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Add "spring" to transition-timing-function value autocompletion
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js (202710 => 202711)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2016-06-30 22:06:44 UTC (rev 202710)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2016-06-30 22:14:20 UTC (rev 202711)
@@ -196,7 +196,7 @@
let hasOtherNonPinnedTabs = this._parentTabBar.tabBarItems.some((item) => item !== this && !item.pinned);
let contextMenu = WebInspector.ContextMenu.createFromEvent(event);
- contextMenu.appendItem(WebInspector.UIString("Close Tab"), closeTab, !hasOtherNonPinnedTabs);
+ contextMenu.appendItem(WebInspector.UIString("Close Tab"), closeTab, this.isDefaultTab);
contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs, !hasOtherNonPinnedTabs);
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
