Title: [203748] trunk/Websites/perf.webkit.org
- Revision
- 203748
- Author
- rn...@webkit.org
- Date
- 2016-07-26 16:15:14 -0700 (Tue, 26 Jul 2016)
Log Message
REGRESSION: Tooltip for analysis tasks doesn't show up on charts
https://bugs.webkit.org/show_bug.cgi?id=160221
Rubber-stamped by Chris Dumez.
The bug was caused by ChartPaneBase resetting annotation bars every time the current point has moved.
Avoid doing this in ChartPaneBase's _renderAnnotations().
* public/v3/components/chart-pane-base.js:
(ChartPaneBase):
(ChartPaneBase.prototype.fetchAnalysisTasks):
(ChartPaneBase.prototype._renderAnnotations):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (203747 => 203748)
--- trunk/Websites/perf.webkit.org/ChangeLog 2016-07-26 23:06:34 UTC (rev 203747)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-07-26 23:15:14 UTC (rev 203748)
@@ -1,5 +1,20 @@
2016-07-26 Ryosuke Niwa <rn...@webkit.org>
+ REGRESSION: Tooltip for analysis tasks doesn't show up on charts
+ https://bugs.webkit.org/show_bug.cgi?id=160221
+
+ Rubber-stamped by Chris Dumez.
+
+ The bug was caused by ChartPaneBase resetting annotation bars every time the current point has moved.
+ Avoid doing this in ChartPaneBase's _renderAnnotations().
+
+ * public/v3/components/chart-pane-base.js:
+ (ChartPaneBase):
+ (ChartPaneBase.prototype.fetchAnalysisTasks):
+ (ChartPaneBase.prototype._renderAnnotations):
+
+2016-07-26 Ryosuke Niwa <rn...@webkit.org>
+
REGRESSION: The arrow indicating the current page doesn't get updated
https://bugs.webkit.org/show_bug.cgi?id=160185
Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js (203747 => 203748)
--- trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2016-07-26 23:06:34 UTC (rev 203747)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2016-07-26 23:15:14 UTC (rev 203748)
@@ -18,6 +18,7 @@
this._mainChartStatus = null;
this._commitLogViewer = null;
this._tasksForAnnotations = null;
+ this._renderedAnnotations = false;
}
configure(platformId, metricId)
@@ -92,6 +93,7 @@
var self = this;
AnalysisTask.fetchByPlatformAndMetric(this._platformId, this._metricId, noCache).then(function (tasks) {
self._tasksForAnnotations = tasks;
+ self._renderedAnnotations = false;
self.render();
});
}
@@ -225,8 +227,9 @@
_renderAnnotations()
{
- if (!this._tasksForAnnotations)
+ if (!this._tasksForAnnotations || this._renderedAnnotations)
return;
+ this._renderedAnnotations = true;
var annotations = this._tasksForAnnotations.map(function (task) {
var fillStyle = '#fc6';
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
