Title: [203886] branches/safari-602-branch/Source/WebCore
- Revision
- 203886
- Author
- bshaf...@apple.com
- Date
- 2016-07-29 00:12:42 -0700 (Fri, 29 Jul 2016)
Log Message
Merge r203775. rdar://problem/23325160
Modified Paths
Diff
Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (203885 => 203886)
--- branches/safari-602-branch/Source/WebCore/ChangeLog 2016-07-29 07:12:39 UTC (rev 203885)
+++ branches/safari-602-branch/Source/WebCore/ChangeLog 2016-07-29 07:12:42 UTC (rev 203886)
@@ -1,5 +1,23 @@
2016-07-28 Babak Shafiei <bshaf...@apple.com>
+ Merge r203775. rdar://problem/23325160
+
+ 2016-07-27 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [Soup] Test http/tests/xmlhttprequest/auth-reject-protection-space.html fails since added in r203743
+ https://bugs.webkit.org/show_bug.cgi?id=160235
+
+ Reviewed by Michael Catanzaro.
+
+ It times out in release and crashes in debug due to an ASSERT_NOT_REACHED(). The soup backend doesn't really
+ support rejecting the protection space and continuing with the next one, but we can at least continue with the
+ request without crendential to make the test pass.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::receivedChallengeRejection):
+
+2016-07-28 Babak Shafiei <bshaf...@apple.com>
+
Merge r203743. rdar://problem/23325160
2016-07-26 David Kilzer <ddkil...@apple.com>
Modified: branches/safari-602-branch/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (203885 => 203886)
--- branches/safari-602-branch/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-07-29 07:12:39 UTC (rev 203885)
+++ branches/safari-602-branch/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-07-29 07:12:42 UTC (rev 203886)
@@ -1247,9 +1247,11 @@
ASSERT_NOT_REACHED();
}
-void ResourceHandle::receivedChallengeRejection(const AuthenticationChallenge&)
+void ResourceHandle::receivedChallengeRejection(const AuthenticationChallenge& challenge)
{
- ASSERT_NOT_REACHED();
+ // This is only used by layout tests, soup based ports don't implement this.
+ notImplemented();
+ receivedRequestToContinueWithoutCredential(challenge);
}
static bool waitingToSendRequest(ResourceHandle* handle)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
