Title: [204731] trunk/LayoutTests
Revision
204731
Author
dba...@webkit.org
Date
2016-08-22 12:12:09 -0700 (Mon, 22 Aug 2016)

Log Message

Attempt to fix the iOS 9 Simulator test bots after <https://trac.webkit.org/changeset/204720>
(https://bugs.webkit.org/show_bug.cgi?id=156857)

Fix _javascript_ TypeErrors, "undefined is not an object". Both uiController.singleTapAtPoint() and
testRunner.runUIScript() expect to be passed a callback function.

Additionally, explicitly check that window.testRunner is non-null before checking whether
testRunner.runUIScript is non-null to avoid a _javascript_ TypeError in desktop Safari.

* http/tests/navigation/ping-attribute/resources/utilities.js:
(clickElement):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (204730 => 204731)


--- trunk/LayoutTests/ChangeLog	2016-08-22 19:03:32 UTC (rev 204730)
+++ trunk/LayoutTests/ChangeLog	2016-08-22 19:12:09 UTC (rev 204731)
@@ -1,3 +1,17 @@
+2016-08-22  Daniel Bates  <daba...@apple.com>
+
+        Attempt to fix the iOS 9 Simulator test bots after <https://trac.webkit.org/changeset/204720>
+        (https://bugs.webkit.org/show_bug.cgi?id=156857)
+
+        Fix _javascript_ TypeErrors, "undefined is not an object". Both uiController.singleTapAtPoint() and
+        testRunner.runUIScript() expect to be passed a callback function.
+
+        Additionally, explicitly check that window.testRunner is non-null before checking whether
+        testRunner.runUIScript is non-null to avoid a _javascript_ TypeError in desktop Safari.
+
+        * http/tests/navigation/ping-attribute/resources/utilities.js:
+        (clickElement):
+
 2016-08-22  Chris Dumez  <cdu...@apple.com>
 
         Add support for GlobalEventHandlers.oncuechange attribute

Modified: trunk/LayoutTests/http/tests/navigation/ping-attribute/resources/utilities.js (204730 => 204731)


--- trunk/LayoutTests/http/tests/navigation/ping-attribute/resources/utilities.js	2016-08-22 19:03:32 UTC (rev 204730)
+++ trunk/LayoutTests/http/tests/navigation/ping-attribute/resources/utilities.js	2016-08-22 19:12:09 UTC (rev 204731)
@@ -37,8 +37,8 @@
     var x = element.offsetLeft + 2;
     var y = element.offsetTop + 2;
     var supportsTouchEvents = "TouchEvent" in window;
-    if (testRunner.runUIScript && supportsTouchEvents)
-        testRunner.runUIScript("(function() { uiController.singleTapAtPoint(" + x + ", " + y + "); })()");
+    if (supportsTouchEvents && window.testRunner && testRunner.runUIScript)
+        testRunner.runUIScript("(function() { uiController.singleTapAtPoint(" + x + ", " + y + ", function() { /* Do nothing */ }); })();", function () { /* Do nothing */ });
     else if (window.eventSender) {
         eventSender.mouseMoveTo(x, y);
         eventSender.mouseDown();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to