Title: [205159] trunk/Source/WebKit2
- Revision
- 205159
- Author
- ander...@apple.com
- Date
- 2016-08-29 16:23:56 -0700 (Mon, 29 Aug 2016)
Log Message
Get rid of ChildProcessProxy::fromConnection
https://bugs.webkit.org/show_bug.cgi?id=161357
Reviewed by Tim Horton.
* UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::fromConnection): Deleted.
* UIProcess/ChildProcessProxy.h:
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::fromConnection): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (205158 => 205159)
--- trunk/Source/WebKit2/ChangeLog 2016-08-29 23:19:14 UTC (rev 205158)
+++ trunk/Source/WebKit2/ChangeLog 2016-08-29 23:23:56 UTC (rev 205159)
@@ -1,5 +1,18 @@
2016-08-29 Anders Carlsson <ander...@apple.com>
+ Get rid of ChildProcessProxy::fromConnection
+ https://bugs.webkit.org/show_bug.cgi?id=161357
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/ChildProcessProxy.cpp:
+ (WebKit::ChildProcessProxy::fromConnection): Deleted.
+ * UIProcess/ChildProcessProxy.h:
+ * UIProcess/WebProcessProxy.h:
+ (WebKit::WebProcessProxy::fromConnection): Deleted.
+
+2016-08-29 Anders Carlsson <ander...@apple.com>
+
Remove the last uses of WebProcessProxy::fromConnection
https://bugs.webkit.org/show_bug.cgi?id=161355
Modified: trunk/Source/WebKit2/UIProcess/ChildProcessProxy.cpp (205158 => 205159)
--- trunk/Source/WebKit2/UIProcess/ChildProcessProxy.cpp 2016-08-29 23:19:14 UTC (rev 205158)
+++ trunk/Source/WebKit2/UIProcess/ChildProcessProxy.cpp 2016-08-29 23:23:56 UTC (rev 205159)
@@ -46,16 +46,6 @@
}
}
-ChildProcessProxy* ChildProcessProxy::fromConnection(IPC::Connection* connection)
-{
- ASSERT(connection);
-
- ChildProcessProxy* childProcessProxy = static_cast<ChildProcessProxy*>(connection->client());
- ASSERT(childProcessProxy->connection() == connection);
-
- return childProcessProxy;
-}
-
void ChildProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions)
{
if (const char* userDirectorySuffix = getenv("DIRHELPER_USER_DIR_SUFFIX"))
Modified: trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h (205158 => 205159)
--- trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2016-08-29 23:19:14 UTC (rev 205158)
+++ trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2016-08-29 23:23:56 UTC (rev 205159)
@@ -40,9 +40,6 @@
ChildProcessProxy();
virtual ~ChildProcessProxy();
- // FIXME: This function does an unchecked upcast, and it is only used in a deprecated code path. Would like to get rid of it.
- static ChildProcessProxy* fromConnection(IPC::Connection*);
-
void connect();
void terminate();
Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.h (205158 => 205159)
--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2016-08-29 23:19:14 UTC (rev 205158)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.h 2016-08-29 23:23:56 UTC (rev 205159)
@@ -73,11 +73,6 @@
static Ref<WebProcessProxy> create(WebProcessPool&);
~WebProcessProxy();
- static WebProcessProxy* fromConnection(IPC::Connection* connection)
- {
- return static_cast<WebProcessProxy*>(ChildProcessProxy::fromConnection(connection));
- }
-
WebConnection* webConnection() const { return m_webConnection.get(); }
WebProcessPool& processPool() { return m_processPool; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
