Title: [205424] trunk/Source/WebInspectorUI
Revision
205424
Author
joep...@webkit.org
Date
2016-09-04 22:01:57 -0700 (Sun, 04 Sep 2016)

Log Message

Web Inspector: Update ESLint rules and run it over most of UserInterface
https://bugs.webkit.org/show_bug.cgi?id=161561

Reviewed by Brian Burg.

* .eslintrc:
Updated ESLint rules.

* UserInterface/Base/InspectorFrontendHostStub.js:
* UserInterface/Base/Main.js:
* UserInterface/Base/Object.js:
* UserInterface/Base/Platform.js:
* UserInterface/Base/Setting.js:
* UserInterface/Controllers/CSSStyleManager.js:
* UserInterface/Controllers/CodeMirrorCompletionController.js:
* UserInterface/Controllers/CodeMirrorTextKillController.js:
* UserInterface/Controllers/DebuggerManager.js:
* UserInterface/Controllers/DragToAdjustController.js:
* UserInterface/Controllers/ReplayManager.js:
* UserInterface/Controllers/SourceMapManager.js:
* UserInterface/Controllers/TimelineManager.js:
* UserInterface/Controllers/TypeTokenAnnotator.js:
* UserInterface/Controllers/VisualStyleCompletionsController.js:
* UserInterface/Debug/Bootstrap.js:
* UserInterface/Debug/UncaughtExceptionReporter.js:
* UserInterface/Models/CSSRule.js:
* UserInterface/Models/CallingContextTree.js:
* UserInterface/Models/CallingContextTreeNode.js:
* UserInterface/Models/ConsoleCommandResultMessage.js:
* UserInterface/Models/CookieStorageObject.js:
* UserInterface/Models/Frame.js:
* UserInterface/Models/Geometry.js:
* UserInterface/Models/IssueMessage.js:
* UserInterface/Models/LayoutTimelineRecord.js:
* UserInterface/Models/MemoryTimeline.js:
* UserInterface/Models/NativeFunctionParameters.js:
* UserInterface/Models/ProfileNode.js:
* UserInterface/Models/RenderingFrameTimelineRecord.js:
* UserInterface/Models/Resource.js:
* UserInterface/Models/ScriptSyntaxTree.js:
* UserInterface/Models/ScriptTimelineRecord.js:
* UserInterface/Models/StackTrace.js:
* UserInterface/Models/TypeSet.js:
* UserInterface/Models/WrappedPromise.js:
* UserInterface/Protocol/InspectorBackend.js:
* UserInterface/Protocol/InspectorFrontendAPI.js:
* UserInterface/Protocol/RemoteObject.js:
* UserInterface/Protocol/ScriptProfilerObserver.js:
* UserInterface/Test/FrontendTestHarness.js:
* UserInterface/Test/InspectorProtocol.js:
* UserInterface/Test/ProtocolTestHarness.js:
* UserInterface/Test/Test.js:
* UserInterface/Test/TestHarness.js:
* UserInterface/Test/TestSuite.js:
* UserInterface/Workers/Formatter/EsprimaFormatter.js:
* UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/.eslintrc (205423 => 205424)


--- trunk/Source/WebInspectorUI/.eslintrc	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/.eslintrc	2016-09-05 05:01:57 UTC (rev 205424)
@@ -27,12 +27,12 @@
     "env": {
         "browser": true,
         "es6": true,
-        "node": false,
+        "worker": true,
     },
     "globals": {
+        // Agents
         "ApplicationCacheAgent": true,
         "CSSAgent": true,
-        "CodeMirror": true,
         "ConsoleAgent": true,
         "DOMAgent": true,
         "DOMDebuggerAgent": true,
@@ -39,25 +39,54 @@
         "DOMStorageAgent": true,
         "DatabaseAgent": true,
         "DebuggerAgent": true,
-        "Formatter": true,
-        "FormatterContentBuilder": true,
+        "HeapAgent",
         "IndexedDBAgent": true,
         "InspectorAgent": true,
-        "InspectorBackend": true,
-        "InspectorFrontendAPI": true,
-        "InspectorFrontendHost": true,
         "LayerTreeAgent": true,
-        "Map": true,
+        "MemoryAgent": true,
         "NetworkAgent": true,
         "PageAgent": true,
         "ReplayAgent": true,
         "RuntimeAgent": true,
+        "ScriptProfilerAgent": true,
         "TimelineAgent": true,
+        "WorkerAgent": true,
+
+        // WebInspector
+        "AsyncTestSuite": true,
+        "Formatter": true,
+        "FormatterContentBuilder": true,
+        "FrontendTestHarness": true,
+        "InspectorBackend": true,
+        "InspectorBackendClass": true,
+        "InspectorFrontendAPI": true,
+        "InspectorFrontendHost": true,
+        "InspectorProtocol": true,
+        "InspectorTest": true,
+        "LinkedList": true,
+        "ListMultimap": true,
+        "ProtocolTest": true,
+        "ProtocolTestHarness": true,
+        "SyncTestSuite": true,
+        "TestHarness": true,
+        "TestSuite": true,
         "WebInspector": true,
+
+        // Externals
+        "CodeMirror": true,
+        "esprima": true,
+
+        // DOM
+        "CSSPrimitiveValue": true,
+        "Exception": true,
+        "SQLException": true,
         "WebKitPoint": true,
-        "WorkerAgent": true,
-        "console": true,
-        // utilities
+
+        // Utilities
+        "figureDash": true,
+        "ellipsis": true,
+        "emDash": true,
+        "enDash": true,
         "clamp": true,
         "isEnterKey": true,
         "isEmptyObject": true,
@@ -65,29 +94,44 @@
         "isFunctionStringNativeCode": true,
         "parseMIMEType": true,
         "doubleQuotedString": true,
-        // image utilities
+        "isWebKitInternalScript": true,
+        "isWebInspectorInternalScript": true,
+        "isWebInspectorConsoleEvaluationScript": true,
+        "appendWebInspectorSourceURL": true,
+        "appendWebInspectorConsoleEvaluationSourceURL": true,
+        "timestamp": true,
+        "handlePromiseException": true,
+
+        // Image Utilities
         "platformImagePath": true,
         "wrappedSVGDocument": true,
-        // url utilities
+        "createSVGElement": true,
+        "useSVGSymbol": true,
+
+        // URL Utilities
         "absoluteURL": true,
         "parseQueryString": true,
         "parseURL": true,
         "parseSecurityOrigin": true,
         "removeURLFragment": true,
-        // externals
-        "esprima": true,
+        "decodeBase64ToBlob": true,
+        "relativePath": true,
+        "parseDataURL": true,
+        "parseLocationQueryParameters": true,
     },
     "rules": {
+        "comma-dangle": 0,
         "consistent-return": 2,
         "curly": 0,
-        "comma-dangle": 0,
         "dot-notation": 0,
         "eqeqeq": 2,
+        "keyword-spacing": 2,
         "new-cap": 0,
         "new-parens": 0,
         "no-console": 0,
         "no-constant-condition": 0,
         "no-extra-bind": 2,
+        "no-extra-parens": [2, "all", {"nestedBinaryExpressions": false}],
         "no-extra-semi": 2,
         "no-inner-declarations": 0,
         "no-new": 0,
@@ -97,15 +141,13 @@
         "no-shadow": 0,
         "no-trailing-spaces": 2,
         "no-undef": 2,
-        "no-unused-vars": [2, {"vars": "all", "args": "none"}],
         "no-underscore-dangle": 0,
         "no-unused-expressions": 2,
+        "no-unused-vars": [2, {"vars": "all", "args": "none"}],
         "no-use-before-define": 0,
-        "no-wrap-func": 2,
         "quotes": [2, "double"],
         "semi": 2,
         "space-infix-ops": 2,
-        "space-return-throw-case": 2,
         "strict": 0,
         "valid-typeof": 2,
     }

Modified: trunk/Source/WebInspectorUI/ChangeLog (205423 => 205424)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-09-05 05:01:57 UTC (rev 205424)
@@ -1,3 +1,62 @@
+2016-09-04  Joseph Pecoraro  <pecor...@apple.com>
+
+        Web Inspector: Update ESLint rules and run it over most of UserInterface
+        https://bugs.webkit.org/show_bug.cgi?id=161561
+
+        Reviewed by Brian Burg.
+
+        * .eslintrc:
+        Updated ESLint rules.
+
+        * UserInterface/Base/InspectorFrontendHostStub.js:
+        * UserInterface/Base/Main.js:
+        * UserInterface/Base/Object.js:
+        * UserInterface/Base/Platform.js:
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Controllers/CSSStyleManager.js:
+        * UserInterface/Controllers/CodeMirrorCompletionController.js:
+        * UserInterface/Controllers/CodeMirrorTextKillController.js:
+        * UserInterface/Controllers/DebuggerManager.js:
+        * UserInterface/Controllers/DragToAdjustController.js:
+        * UserInterface/Controllers/ReplayManager.js:
+        * UserInterface/Controllers/SourceMapManager.js:
+        * UserInterface/Controllers/TimelineManager.js:
+        * UserInterface/Controllers/TypeTokenAnnotator.js:
+        * UserInterface/Controllers/VisualStyleCompletionsController.js:
+        * UserInterface/Debug/Bootstrap.js:
+        * UserInterface/Debug/UncaughtExceptionReporter.js:
+        * UserInterface/Models/CSSRule.js:
+        * UserInterface/Models/CallingContextTree.js:
+        * UserInterface/Models/CallingContextTreeNode.js:
+        * UserInterface/Models/ConsoleCommandResultMessage.js:
+        * UserInterface/Models/CookieStorageObject.js:
+        * UserInterface/Models/Frame.js:
+        * UserInterface/Models/Geometry.js:
+        * UserInterface/Models/IssueMessage.js:
+        * UserInterface/Models/LayoutTimelineRecord.js:
+        * UserInterface/Models/MemoryTimeline.js:
+        * UserInterface/Models/NativeFunctionParameters.js:
+        * UserInterface/Models/ProfileNode.js:
+        * UserInterface/Models/RenderingFrameTimelineRecord.js:
+        * UserInterface/Models/Resource.js:
+        * UserInterface/Models/ScriptSyntaxTree.js:
+        * UserInterface/Models/ScriptTimelineRecord.js:
+        * UserInterface/Models/StackTrace.js:
+        * UserInterface/Models/TypeSet.js:
+        * UserInterface/Models/WrappedPromise.js:
+        * UserInterface/Protocol/InspectorBackend.js:
+        * UserInterface/Protocol/InspectorFrontendAPI.js:
+        * UserInterface/Protocol/RemoteObject.js:
+        * UserInterface/Protocol/ScriptProfilerObserver.js:
+        * UserInterface/Test/FrontendTestHarness.js:
+        * UserInterface/Test/InspectorProtocol.js:
+        * UserInterface/Test/ProtocolTestHarness.js:
+        * UserInterface/Test/Test.js:
+        * UserInterface/Test/TestHarness.js:
+        * UserInterface/Test/TestSuite.js:
+        * UserInterface/Workers/Formatter/EsprimaFormatter.js:
+        * UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:
+
 2016-09-04  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r205415.

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -30,13 +30,6 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-if (!window.Symbol) {
-    window.Symbol = function(string)
-    {
-        return string;
-    }
-}
-
 if (!window.InspectorFrontendHost) {
     WebInspector.InspectorFrontendHostStub = function()
     {

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -474,7 +474,7 @@
 WebInspector.knownTabClasses = function()
 {
     return new Set(this._knownTabClassesByType.values());
-}
+};
 
 WebInspector._showOpenResourceDialog = function()
 {
@@ -485,7 +485,7 @@
         return;
 
     this._openResourceDialog.present(this._contentElement);
-}
+};
 
 WebInspector._createTabContentViewForType = function(tabType)
 {
@@ -563,7 +563,7 @@
     this._pendingOpenTabs = stillPendingOpenTabs;
 
     this._updateNewTabButtonState();
-}
+};
 
 WebInspector.showNewTabTab = function(shouldAnimate)
 {
@@ -634,7 +634,7 @@
 
     this._tryToRestorePendingTabs();
     this.notifications.dispatchEventToListeners(WebInspector.Notification.TabTypesChanged);
-}
+};
 
 WebInspector.activateExtraDomains = function(domains)
 {
@@ -736,7 +736,7 @@
 {
     this.visible = visible;
     this.notifications.dispatchEventToListeners(WebInspector.Notification.VisibilityStateDidChange);
-}
+};
 
 WebInspector.handlePossibleLinkClick = function(event, frame, alwaysOpenExternally)
 {
@@ -1000,7 +1000,7 @@
     // (such as in Debug UI) or in text that is standardized in English.
     // For example, CSS property names and values are never localized.
     return string;
-}
+};
 
 WebInspector.UIString = function(string, vararg)
 {
@@ -1485,7 +1485,7 @@
 WebInspector.isDebugUIEnabled = function()
 {
     return WebInspector.showDebugUISetting && WebInspector.showDebugUISetting.value;
-}
+};
 
 WebInspector._undock = function(event)
 {
@@ -1953,7 +1953,7 @@
     var contentBrowser = this._focusedOrVisibleContentBrowser();
     if (!contentBrowser || typeof contentBrowser.handleFindEvent !== "function")
         return;
-    
+
     contentBrowser.handleFindEvent(event);
 };
 
@@ -2042,7 +2042,7 @@
 WebInspector._zoomFactor = function()
 {
     return this._zoomFactorSetting.value;
-}
+};
 
 WebInspector._setZoomFactor = function(factor)
 {
@@ -2049,7 +2049,7 @@
     InspectorFrontendHost.setZoomFactor(factor);
     // Round-trip through the frontend host API in case the requested factor is not used.
     this._zoomFactorSetting.value = InspectorFrontendHost.zoomFactor();
-}
+};
 
 WebInspector._showTabAtIndex = function(i, event)
 {
@@ -2120,13 +2120,8 @@
 
 WebInspector.createGoToArrowButton = function()
 {
-    function stopPropagation(event)
-    {
-        event.stopPropagation()
-    }
-
     var button = document.createElement("button");
-    button.addEventListener("mousedown", stopPropagation, true);
+    button.addEventListener("mousedown", (event) => { event.stopPropagation(); }, true);
     button.className = "go-to-arrow";
     button.tabIndex = -1;
     return button;
@@ -2236,7 +2231,7 @@
         container.append(nonLink);
 
         var title = linkString;
-        var realURL = (linkString.startsWith("www.") ? "http://" + linkString : linkString);
+        var realURL = linkString.startsWith("www.") ? "http://" + linkString : linkString;
         var lineColumnMatch = lineColumnRegEx.exec(realURL);
         if (lineColumnMatch)
             realURL = realURL.substring(0, realURL.length - lineColumnMatch[0].length);
@@ -2286,7 +2281,7 @@
     linkNode.textContent = (resource.urlComponents.lastPathComponent || resource.url).insertWordBreakCharacters();
     linkNode.addEventListener("click", handleClick.bind(this));
     return linkNode;
-}
+};
 
 WebInspector._undoKeyboardShortcut = function(event)
 {
@@ -2435,7 +2430,7 @@
         return false;
 
     if (!WebInspector.frameResourceManager.mainFrame || !WebInspector.frameResourceManager.mainFrame.mainResource)
-        return;
+        return false;
 
     return WebInspector.Resource.typeFromMIMEType(WebInspector.frameResourceManager.mainFrame.mainResource.mimeType) === WebInspector.Resource.Type.Document;
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Object.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Object.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Object.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -38,11 +38,11 @@
 
         console.assert(eventType, "Object.addEventListener: invalid event type ", eventType, "(listener: ", listener, "thisObject: ", thisObject, ")");
         if (!eventType)
-            return;
+            return null;
 
         console.assert(listener, "Object.addEventListener: invalid listener ", listener, "(event type: ", eventType, "thisObject: ", thisObject, ")");
         if (!listener)
-            return;
+            return null;
 
         if (!this._listeners)
             this._listeners = new Map();

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Platform.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Platform.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Platform.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -43,7 +43,7 @@
     if (osVersionMatch && osVersionMatch[1] === "10") {
         WebInspector.Platform.version.base = 10;
         WebInspector.Platform.version.release = parseInt(osVersionMatch[2]);
-        switch(osVersionMatch[2]) {
+        switch (osVersionMatch[2]) {
             case "11":
                 WebInspector.Platform.version.name = "el-capitan";
                 break;

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -61,7 +61,7 @@
         if (!window.InspectorTest && window.localStorage && this._localStorageKey in window.localStorage) {
             try {
                 this._value = JSON.parse(window.localStorage[this._localStorageKey]);
-            } catch(e) {
+            } catch (e) {
                 delete window.localStorage[this._localStorageKey];
             }
         }
@@ -83,7 +83,7 @@
                     delete window.localStorage[this._localStorageKey];
                 else
                     window.localStorage[this._localStorageKey] = JSON.stringify(this._value);
-            } catch(e) {
+            } catch (e) {
                 console.error("Error saving setting with name: " + this._name);
             }
         }

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -497,7 +497,7 @@
             if (!styleSheet.url)
                 return;
 
-            var resource = styleSheet.parentFrame.resourceForURL(styleSheet.url);;
+            var resource = styleSheet.parentFrame.resourceForURL(styleSheet.url);
             if (!resource)
                 return;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -416,7 +416,6 @@
 
         var bracketStack = [];
         var bracketOffsetStack = [];
-        var lastCloseBracketOffset = NaN;
 
         var startOffset = endOffset;
         var firstOffset = endOffset + direction;

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -99,7 +99,7 @@
         let killedText;
         if (change.to.line === change.from.line + 1 && change.removed.length === 2) {
             // An entire line was deleted, including newline (deleteLine).
-            if (change.removed[0].length && !change.removed[1].length) 
+            if (change.removed[0].length && !change.removed[1].length)
                 killedText = change.removed[0] + "\n";
             // A newline was killed by itself (Ctrl-K).
             else

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -284,7 +284,6 @@
         console.assert(sourceCode instanceof WebInspector.Resource || sourceCode instanceof WebInspector.Script);
 
         if (sourceCode instanceof WebInspector.SourceMapResource) {
-            var mappedResourceBreakpoints = [];
             var originalSourceCodeBreakpoints = this.breakpointsForSourceCode(sourceCode.sourceMap.originalSourceCode);
             return originalSourceCodeBreakpoints.filter(function(breakpoint) {
                 return breakpoint.sourceCodeLocation.displaySourceCode === sourceCode;

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DragToAdjustController.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DragToAdjustController.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DragToAdjustController.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -108,7 +108,7 @@
 
     handleEvent(event)
     {
-        switch(event.type) {
+        switch (event.type) {
         case "mouseenter":
             if (!this._dragging) {
                 if (this._delegate && typeof this._delegate.dragToAdjustControllerCanBeActivated === "function")

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -341,7 +341,7 @@
                 console.assert(manager.sessionState !== WebInspector.ReplayManager.SessionState.Capturing);
                 console.assert(manager.segmentState === WebInspector.ReplayManager.SegmentState.Loaded || manager.segmentState === WebInspector.ReplayManager.SegmentState.Unloaded);
 
-                return ReplayAgent.replayToCompletion(manager.playbackSpeed === WebInspector.ReplayManager.PlaybackSpeed.FastForward)
+                return ReplayAgent.replayToCompletion(manager.playbackSpeed === WebInspector.ReplayManager.PlaybackSpeed.FastForward);
             }).catch(function(error) {
                 console.error("Failed to start playback to completion: ", error);
                 throw error;

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -113,7 +113,7 @@
                 var baseURL = sourceMapURL.startsWith("data:") ? originalSourceCode.url : sourceMapURL;
                 var sourceMap = new WebInspector.SourceMap(baseURL, payload, originalSourceCode);
                 this._loadAndParseSucceeded(sourceMapURL, sourceMap);
-            } catch(e) {
+            } catch (e) {
                 this._loadAndParseFailed(sourceMapURL);
             }
         }

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -989,12 +989,12 @@
 
     _mergeScriptProfileRecords()
     {
-        let nextRecord = function(list) { return list.shift() || null; }
+        let nextRecord = function(list) { return list.shift() || null; };
         let nextWebTimelineRecord = nextRecord.bind(null, this._webTimelineScriptRecordsExpectingScriptProfilerEvents);
         let nextScriptProfilerRecord = nextRecord.bind(null, this._scriptProfilerRecords);
         let recordEnclosesRecord = function(record1, record2) {
             return record1.startTime <= record2.startTime && record1.endTime >= record2.endTime;
-        }
+        };
 
         let webRecord = nextWebTimelineRecord();
         let profilerRecord = nextScriptProfilerRecord();

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -100,7 +100,7 @@
         if (!functionReturnType || !functionReturnType.valid)
             return;
 
-        // If a function does not have an explicit return statement with an argument (i.e, "return x;" instead of "return;") 
+        // If a function does not have an explicit return statement with an argument (i.e, "return x;" instead of "return;")
         // then don't show a return type unless we think it's a constructor.
         var scriptSyntaxTree = this._script._scriptSyntaxTree;
         if (!node.attachments.__typeToken && (scriptSyntaxTree.containsNonEmptyReturnStatement(node.body) || !functionReturnType.typeSet.isContainedIn(WebInspector.TypeSet.TypeBit.Undefined))) {

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/VisualStyleCompletionsController.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/VisualStyleCompletionsController.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/VisualStyleCompletionsController.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -51,7 +51,7 @@
     get currentCompletion()
     {
         if (!this.hasCompletions)
-            return;
+            return null;
 
         return this._currentCompletions[this._selectedCompletionIndex] || null;
     }
@@ -129,4 +129,4 @@
 
 WebInspector.VisualStyleCompletionsController.Event = {
     CompletionSelected: "visual-style-completions-controller-completion-selected"
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -58,4 +58,4 @@
     });
 
     updateDebugUI();
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -166,7 +166,7 @@
 
         if (entry.details) {
             lines.push("");
-            lines.push("Additional Details:")
+            lines.push("Additional Details:");
             for (let key in entry.details) {
                 let value = entry.details[key];
                 lines.push(`${indent}${key} --> ${value}`);

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSRule.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSRule.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSRule.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -176,7 +176,7 @@
     get mediaText()
     {
         if (!this._mediaList.length)
-            return;
+            return "";
 
         let mediaText = "";
         for (let media of this._mediaList)

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTree.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTree.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTree.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -106,7 +106,7 @@
 
         this._root.forEachChild((child) => {
             if (child.hasStackTraceInTimeRange(startTime, endTime))
-                roots.push(child.toCPUProfileNode(numSamplesInTimeRange, startTime, endTime)); 
+                roots.push(child.toCPUProfileNode(numSamplesInTimeRange, startTime, endTime));
         });
 
         cpuProfile.rootNodes = roots;

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTreeNode.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTreeNode.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CallingContextTreeNode.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -72,7 +72,7 @@
         }
         return false;
     }
-    
+
     hasStackTraceInTimeRange(startTime, endTime)
     {
         console.assert(startTime <= endTime);
@@ -153,7 +153,7 @@
         if (!expressionLocation)
             return;
 
-        let {line, column} = expressionLocation;    
+        let {line, column} = expressionLocation;
         let hashCons = line + ":" + column;
         let timestamps = this._expressionLocations[hashCons];
         if (!timestamps) {

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -32,7 +32,7 @@
     constructor(result, wasThrown, savedResultIndex, shouldRevealConsole = true)
     {
         let source = WebInspector.ConsoleMessage.MessageSource.JS;
-        let level = (wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log);
+        let level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log;
         let type = WebInspector.ConsoleMessage.MessageType.Result;
 
         super(source, level, "", type, undefined, undefined, undefined, 0, [result], undefined, undefined);

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CookieStorageObject.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CookieStorageObject.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CookieStorageObject.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -38,9 +38,9 @@
         if (!parsedURL || !WebInspector.CookieStorageObject.cookieDomainMatchesResourceDomain(cookie.domain, parsedURL.host))
             return false;
 
-        return (parsedURL.path.startsWith(cookie.path)
+        return parsedURL.path.startsWith(cookie.path)
             && (!cookie.port || parsedURL.port === cookie.port)
-            && (!cookie.secure || parsedURL.scheme === "https"));
+            && (!cookie.secure || parsedURL.scheme === "https");
     }
 
     static cookieDomainMatchesResourceDomain(cookieDomain, resourceDomain)

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Frame.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/Frame.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Frame.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -472,7 +472,7 @@
 
     _isProvisionalResource(resource)
     {
-        return (resource.loaderIdentifier && this._provisionalLoaderIdentifier && resource.loaderIdentifier === this._provisionalLoaderIdentifier);
+        return resource.loaderIdentifier && this._provisionalLoaderIdentifier && resource.loaderIdentifier === this._provisionalLoaderIdentifier;
     }
 
     _associateWithResource(resource)

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Geometry.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/Geometry.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Geometry.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -58,7 +58,7 @@
 
     equals(anotherPoint)
     {
-        return (this.x === anotherPoint.x && this.y === anotherPoint.y);
+        return this.x === anotherPoint.x && this.y === anotherPoint.y;
     }
 
     distance(anotherPoint)
@@ -91,7 +91,7 @@
 
     equals(anotherSize)
     {
-        return (this.width === anotherSize.width && this.height === anotherSize.height);
+        return this.width === anotherSize.width && this.height === anotherSize.height;
     }
 };
 
@@ -135,7 +135,7 @@
 
     equals(anotherRect)
     {
-        return (this.origin.equals(anotherRect.origin) && this.size.equals(anotherRect.size));
+        return this.origin.equals(anotherRect.origin) && this.size.equals(anotherRect.size);
     }
 
     inset(insets)
@@ -252,8 +252,8 @@
 
     equals(anotherInset)
     {
-        return (this.top === anotherInset.top && this.right === anotherInset.right &&
-                this.bottom === anotherInset.bottom && this.left === anotherInset.left);
+        return this.top === anotherInset.top && this.right === anotherInset.right
+            && this.bottom === anotherInset.bottom && this.left === anotherInset.left;
     }
 
     copy()
@@ -320,7 +320,7 @@
         }
         return new WebInspector.Rect(minX, minY, maxX - minX, maxY - minY);
     }
-}
+};
 
 WebInspector.CubicBezier = class CubicBezier
 {
@@ -333,7 +333,7 @@
         this._curveInfo = {
             x: {c: 3.0 * x1},
             y: {c: 3.0 * y1}
-        }
+        };
 
         this._curveInfo.x.b = 3.0 * (x2 - x1) - this._curveInfo.x.c;
         this._curveInfo.x.a = 1.0 - this._curveInfo.x.c - this._curveInfo.x.b;
@@ -467,7 +467,7 @@
         // Failure.
         return t2;
     }
-}
+};
 
 WebInspector.CubicBezier.keywordValues = {
     "ease":         [0.25, 0.1, 0.25, 1],
@@ -568,4 +568,4 @@
         }
         return t;
     }
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/IssueMessage.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/IssueMessage.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/IssueMessage.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -83,7 +83,7 @@
 
     static displayName(type)
     {
-        switch(type) {
+        switch (type) {
         case WebInspector.IssueMessage.Type.SemanticIssue:
             return WebInspector.UIString("Semantic Issue");
         case WebInspector.IssueMessage.Type.RangeIssue:

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -43,7 +43,7 @@
 
     static displayNameForEventType(eventType)
     {
-        switch(eventType) {
+        switch (eventType) {
         case WebInspector.LayoutTimelineRecord.EventType.InvalidateStyles:
             return WebInspector.UIString("Styles Invalidated");
         case WebInspector.LayoutTimelineRecord.EventType.RecalculateStyles:

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/MemoryTimeline.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/MemoryTimeline.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/MemoryTimeline.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -35,7 +35,7 @@
 
         this._pressureEvents.push(memoryPressureEvent);
 
-        this.dispatchEventToListeners(WebInspector.MemoryTimeline.Event.MemoryPressureEventAdded, {memoryPressureEvent})
+        this.dispatchEventToListeners(WebInspector.MemoryTimeline.Event.MemoryPressureEventAdded, {memoryPressureEvent});
     }
 
     // Protected

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -2187,7 +2187,7 @@
         before: "[node|string]...",
         replaceWith: "[node|string]...",
     };
-    Object.assign(WebInspector.NativePrototypeFunctionParameters.Element, ChildNode)
+    Object.assign(WebInspector.NativePrototypeFunctionParameters.Element, ChildNode);
     Object.assign(WebInspector.NativePrototypeFunctionParameters.CharacterData, ChildNode);
 
     var ParentNode = {

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -50,7 +50,7 @@
         this._nextSibling = null;
         this._computedTotalTimes = false;
 
-        if (this._callInfo) {            
+        if (this._callInfo) {
             this._startTime = this._callInfo.startTime;
             this._endTime = this._callInfo.endTime;
             this._totalTime = this._callInfo.totalTime;

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -42,7 +42,7 @@
 
     static displayNameForTaskType(taskType)
     {
-        switch(taskType) {
+        switch (taskType) {
         case WebInspector.RenderingFrameTimelineRecord.TaskType.Script:
             return WebInspector.UIString("Script");
         case WebInspector.RenderingFrameTimelineRecord.TaskType.Layout:
@@ -56,7 +56,7 @@
 
     static taskTypeForTimelineRecord(record)
     {
-        switch(record.type) {
+        switch (record.type) {
         case WebInspector.TimelineRecord.Type.Script:
             return WebInspector.RenderingFrameTimelineRecord.TaskType.Script;
         case WebInspector.TimelineRecord.Type.Layout:

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -88,7 +88,7 @@
 
     static displayNameForType(type, plural)
     {
-        switch(type) {
+        switch (type) {
         case WebInspector.Resource.Type.Document:
             if (plural)
                 return WebInspector.UIString("Documents");
@@ -717,9 +717,9 @@
 
         if (this.requestDataContentType && this.requestMethod !== "GET" && this.requestData) {
             if (this.requestDataContentType.match(/^application\/x-www-form-urlencoded\s*(;.*)?$/i))
-                command.push("--data " + escapeStringPosix(this.requestData))
+                command.push("--data " + escapeStringPosix(this.requestData));
             else
-                command.push("--data-binary " + escapeStringPosix(this.requestData))
+                command.push("--data-binary " + escapeStringPosix(this.requestData));
         }
 
         let curlCommand = command.join(" \\\n");

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -149,15 +149,15 @@
 
     static functionReturnDivot(node)
     {
-        console.assert(node.type === WebInspector.ScriptSyntaxTree.NodeType.FunctionDeclaration || node.type === WebInspector.ScriptSyntaxTree.NodeType.FunctionExpression || node.type === WebInspector.ScriptSyntaxTree.NodeType.MethodDefinition || node.type === WebInspector.ScriptSyntaxTree.NodeType.ArrowFunctionExpression); 
+        console.assert(node.type === WebInspector.ScriptSyntaxTree.NodeType.FunctionDeclaration || node.type === WebInspector.ScriptSyntaxTree.NodeType.FunctionExpression || node.type === WebInspector.ScriptSyntaxTree.NodeType.MethodDefinition || node.type === WebInspector.ScriptSyntaxTree.NodeType.ArrowFunctionExpression);
 
-        // COMPATIBILITY (iOS 9): Legacy Backends view the return type as being the opening "{" of the function body. 
+        // COMPATIBILITY (iOS 9): Legacy Backends view the return type as being the opening "{" of the function body.
         // After iOS 9, this is to move to the start of the function statement/_expression_. See below:
         // FIXME: Need a better way to determine backend versions. Using DOM.pseudoElement because that was added after iOS 9.
         if (!DOMAgent.hasEvent("pseudoElementAdded"))
             return node.body.range[0];
 
-        // "f" in "function". "s" in "set". "g" in "get". First letter in any method name for classes and object literals. 
+        // "f" in "function". "s" in "set". "g" in "get". First letter in any method name for classes and object literals.
         // The "[" for computed methods in classes and object literals.
         return node.typeProfilingReturnDivot;
     }
@@ -780,7 +780,7 @@
                 type: WebInspector.ScriptSyntaxTree.NodeType.RestElement,
                 argument: this._createInternalSyntaxTree(node.argument)
             };
-            break;            
+            break;
         case "ReturnStatement":
             result = {
                 type: WebInspector.ScriptSyntaxTree.NodeType.ReturnStatement,

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -357,7 +357,7 @@
         WebInspector.ScriptTimelineRecord._eventDisplayNames = nameMap;
     }
 
-    switch(eventType) {
+    switch (eventType) {
     case WebInspector.ScriptTimelineRecord.EventType.ScriptEvaluated:
     case WebInspector.ScriptTimelineRecord.EventType.APIScriptEvaluated:
         return WebInspector.UIString("Script Evaluated");

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -151,5 +151,4 @@
 
         return null;
     }
-    
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/TypeSet.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/TypeSet.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/TypeSet.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -105,8 +105,8 @@
         if (typeSet.isSymbol)
             this._primitiveTypeNames.push("Symbol");
 
-        // It's implied that type Integer is contained in type Number. Don't put 
-        // both 'Integer' and 'Number' into the set because this could imply that 
+        // It's implied that type Integer is contained in type Number. Don't put
+        // both 'Integer' and 'Number' into the set because this could imply that
         // Number means to Double instead of Double|Integer.
         if (typeSet.isNumber)
             this._primitiveTypeNames.push("Number");

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/WrappedPromise.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Models/WrappedPromise.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/WrappedPromise.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -52,4 +52,4 @@
     {
         this._reject(value);
     }
-}
\ No newline at end of file
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -52,7 +52,7 @@
         this._dumpInspectorTimeStats = false;
 
         let setting = WebInspector.autoLogProtocolMessagesSetting = new WebInspector.Setting("auto-collect-protocol-messages", false);
-        setting.addEventListener(WebInspector.Setting.Event.Changed, this._startOrStopAutomaticTracing.bind(this))
+        setting.addEventListener(WebInspector.Setting.Event.Changed, this._startOrStopAutomaticTracing.bind(this));
         this._startOrStopAutomaticTracing();
     }
 
@@ -470,7 +470,7 @@
 // But we can use strict mode to get stricter handling of the code inside its functions.
 InspectorBackend.Command = function(backend, qualifiedName, callSignature, replySignature)
 {
-    'use strict';
+    "use strict";
 
     this._backend = backend;
     this._instance = this;
@@ -484,7 +484,7 @@
 
 InspectorBackend.Command.create = function(backend, commandName, callSignature, replySignature)
 {
-    'use strict';
+    "use strict";
 
     var instance = new InspectorBackend.Command(backend, commandName, callSignature, replySignature);
 
@@ -527,7 +527,7 @@
 
     invoke: function(commandArguments, callback)
     {
-        'use strict';
+        "use strict";
 
         let instance = this._instance;
 
@@ -539,7 +539,7 @@
 
     supports: function(parameterName)
     {
-        'use strict';
+        "use strict";
 
         var instance = this._instance;
         return instance.callSignature.some((parameter) => parameter["name"] === parameterName);
@@ -549,7 +549,7 @@
 
     _invokeWithArguments: function()
     {
-        'use strict';
+        "use strict";
 
         let instance = this._instance;
         let commandArguments = Array.from(arguments);

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -83,7 +83,7 @@
         if (document.readyState !== "complete")
             document.addEventListener("readystatechange", this);
         if (document.visibilityState !== "visible")
-            document.addEventListener("visibilitychange", this);  
+            document.addEventListener("visibilitychange", this);
     },
 
     handleEvent: function(event)
@@ -146,7 +146,7 @@
         var methodName = signature.shift();
         console.assert(InspectorFrontendAPI[methodName], "Unexpected InspectorFrontendAPI method name: " + methodName);
         if (!InspectorFrontendAPI[methodName])
-            return;
+            return null;
 
         return InspectorFrontendAPI[methodName].apply(InspectorFrontendAPI, signature);
     },

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -436,7 +436,7 @@
 
         RuntimeAgent.callFunctionOn(this._objectId, appendWebInspectorSourceURL(functionDeclaration.toString()), args, true, true, mycallback);
     }
-    
+
     invokeGetter(getterRemoteObject, callback)
     {
         console.assert(getterRemoteObject instanceof WebInspector.RemoteObject);
@@ -639,7 +639,7 @@
 WebInspector.RemoteObject.SourceCodeLocationPromise = {
     NoSourceFound: "remote-object-source-code-location-promise-no-source-found",
     MissingObjectId: "remote-object-source-code-location-promise-missing-object-id"
-}
+};
 
 // FIXME: Phase out this deprecated class.
 WebInspector.DeprecatedRemoteObjectProperty = class DeprecatedRemoteObjectProperty

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/ScriptProfilerObserver.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/ScriptProfilerObserver.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/ScriptProfilerObserver.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -41,7 +41,7 @@
     {
         WebInspector.timelineManager.scriptProfilerTrackingCompleted(samples);
     }
-    
+
     programmaticCaptureStarted()
     {
         WebInspector.timelineManager.scriptProfilerProgrammaticCaptureStarted();

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -166,7 +166,7 @@
                         if (frame.indexOf("[native code]") !== -1)
                             frameLocation = "[native code]";
                         else
-                            frameLocation = "(" + frameLocation + ")"
+                            frameLocation = "(" + frameLocation + ")";
 
                         return `#${i}: ${frameName} ${frameLocation}`;
                     });
@@ -173,7 +173,7 @@
                     self.addResult("TRACE: " + Array.from(arguments).join(" "));
                     self.addResult(sanitizedFrames.join("\n"));
                 }
-            }
+            };
         }
 
         let redirectedMethods = {};

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/InspectorProtocol.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/InspectorProtocol.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/InspectorProtocol.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -44,7 +44,7 @@
     this._sendMessage(messageObject);
 
     return this._requestId;
-}
+};
 
 InspectorProtocol.awaitCommand = function(args)
 {
@@ -52,7 +52,7 @@
     let messageObject = {method, params, id: ++this._requestId};
 
     return this.awaitMessage(messageObject);
-}
+};
 
 InspectorProtocol.awaitMessage = function(messageObject)
 {
@@ -70,7 +70,7 @@
         this._dispatchTable[requestId] = {resolve, reject};
         this._sendMessage(messageObject);
     });
-}
+};
 
 InspectorProtocol.awaitEvent = function(args)
 {
@@ -82,9 +82,9 @@
         InspectorProtocol.eventHandler[event] = function(message) {
             InspectorProtocol.eventHandler[event] = undefined;
             resolve(message);
-        }
+        };
     });
-}
+};
 
 InspectorProtocol._sendMessage = function(messageObject)
 {
@@ -94,7 +94,7 @@
         InspectorFrontendHost.unbufferedLog(`frontend: ${messageString}`);
 
     InspectorFrontendHost.sendMessageToBackend(messageString);
-}
+};
 
 InspectorProtocol.addEventListener = function(eventTypeOrObject, listener)
 {
@@ -120,7 +120,7 @@
         throw new Error("Cannot register the same listener more than once.");
 
     listeners.push(listener);
-}
+};
 
 InspectorProtocol.checkForError = function(responseObject)
 {
@@ -129,7 +129,7 @@
         ProtocolTest.completeTest();
         throw "PROTOCOL ERROR";
     }
-}
+};
 
 InspectorProtocol.dispatchMessageFromBackend = function(messageObject)
 {
@@ -179,4 +179,4 @@
                 resolve(messageObject.result);
         }
     }
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/ProtocolTestHarness.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/ProtocolTestHarness.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/ProtocolTestHarness.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -62,7 +62,7 @@
         let args = {
             method: "Runtime.evaluate",
             params: {_expression_}
-        }
+        };
 
         if (typeof callback === "function")
             InspectorProtocol.sendCommand(args, callback);
@@ -75,4 +75,4 @@
         this.dumpActivityToSystemConsole = true;
         this.dumpInspectorProtocolMessages = true;
     }
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/Test.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/Test.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/Test.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -75,7 +75,7 @@
 
     // Global settings.
     this.showShadowDOMSetting = new WebInspector.Setting("show-shadow-dom", true);
-}
+};
 
 WebInspector.contentLoaded = function()
 {
@@ -85,7 +85,7 @@
     // Tell the InspectorFrontendHost we loaded, which causes the window to display
     // and pending InspectorFrontendAPI commands to be sent.
     InspectorFrontendHost.loaded();
-}
+};
 
 WebInspector.isDebugUIEnabled = () => false;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/TestHarness.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/TestHarness.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/TestHarness.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -117,7 +117,7 @@
     {
         if (message instanceof Element)
             return message.textContent;
-        
+
         return (typeof message !== "string") ? JSON.stringify(message) : message;
     }
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Test/TestSuite.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Test/TestSuite.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/TestSuite.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -79,10 +79,10 @@
             throw new Error("Tried to add test case without `test` function.");
 
         if (testcase.setup && typeof testcase.setup !== "function")
-            throw new Error("Tried to add test case with invalid `setup` parameter (must be a function).")
+            throw new Error("Tried to add test case with invalid `setup` parameter (must be a function).");
 
         if (testcase.teardown && typeof testcase.teardown !== "function")
-            throw new Error("Tried to add test case with invalid `teardown` parameter (must be a function).")
+            throw new Error("Tried to add test case with invalid `teardown` parameter (must be a function).");
 
         this.testcases.push(testcase);
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -262,7 +262,7 @@
         }
 
         if (nodeType === "LogicalExpression" || nodeType === "BinaryExpression") {
-            if ((tokenValue !== "(" && tokenValue !== ")")) {
+            if (tokenValue !== "(" && tokenValue !== ")") {
                 builder.appendSpace();
                 builder.appendToken(tokenValue, tokenOffset);
                 builder.appendSpace();
@@ -875,4 +875,4 @@
             console.assert(!programNode.trailingComments);
         }
     }
-}
+};

Modified: trunk/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js (205423 => 205424)


--- trunk/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js	2016-09-05 03:13:00 UTC (rev 205423)
+++ trunk/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js	2016-09-05 05:01:57 UTC (rev 205424)
@@ -88,7 +88,7 @@
     }
 
     // Private
-    
+
     _handleMessage(event)
     {
         let data = ""
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to