Title: [205582] trunk/Source/WebCore
- Revision
- 205582
- Author
- achristen...@apple.com
- Date
- 2016-09-07 21:10:41 -0700 (Wed, 07 Sep 2016)
Log Message
Fix API tests after r205580
https://bugs.webkit.org/show_bug.cgi?id=161668
No new tests, but this fixes API tests on bots.
* platform/URLParser.cpp:
(WebCore::domainToASCII):
This function seems to be appending characters to strings sometimes on some configurations.
This definitely needs further investigation, but this will fix the bots, and nothing else
will be affected because the URLParser is disabled by default.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205581 => 205582)
--- trunk/Source/WebCore/ChangeLog 2016-09-08 01:49:49 UTC (rev 205581)
+++ trunk/Source/WebCore/ChangeLog 2016-09-08 04:10:41 UTC (rev 205582)
@@ -1,3 +1,16 @@
+2016-09-07 Alex Christensen <achristen...@webkit.org>
+
+ Fix API tests after r205580
+ https://bugs.webkit.org/show_bug.cgi?id=161668
+
+ No new tests, but this fixes API tests on bots.
+
+ * platform/URLParser.cpp:
+ (WebCore::domainToASCII):
+ This function seems to be appending characters to strings sometimes on some configurations.
+ This definitely needs further investigation, but this will fix the bots, and nothing else
+ will be affected because the URLParser is disabled by default.
+
2016-09-07 Yusuke Suzuki <utatane....@gmail.com>
Introduce abstract class LoadableScript for classic script and module graph
Modified: trunk/Source/WebCore/platform/URLParser.cpp (205581 => 205582)
--- trunk/Source/WebCore/platform/URLParser.cpp 2016-09-08 01:49:49 UTC (rev 205581)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-09-08 04:10:41 UTC (rev 205582)
@@ -1302,6 +1302,12 @@
}
UChar hostnameBuffer[hostnameBufferLength];
+
+ // FIXME: This is slow, but it covers up a mysterious bug on the bots when logging is disabled.
+ // The URLParser should not be enabled until this bug is found and resolved.
+ // See https://bugs.webkit.org/show_bug.cgi?id=161668
+ memset(hostnameBuffer, 0, sizeof(hostnameBuffer));
+
UErrorCode error = U_ZERO_ERROR;
int32_t numCharactersConverted = uidna_IDNToASCII(StringView(domain).upconvertedCharacters(), domain.length(), hostnameBuffer, hostnameBufferLength, UIDNA_ALLOW_UNASSIGNED, nullptr, &error);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
