Title: [205827] trunk/Source/WebInspectorUI
- Revision
- 205827
- Author
- commit-qu...@webkit.org
- Date
- 2016-09-12 14:46:49 -0700 (Mon, 12 Sep 2016)
Log Message
Web Inspector: Hide ["PrivateSymbol.concatSlowPath"] and other PrivateSymbols from memory edges
https://bugs.webkit.org/show_bug.cgi?id=156763
Patch by Devin Rousso <dcrousso+web...@gmail.com> on 2016-09-12
Reviewed by Joseph Pecoraro.
* UserInterface/Proxies/HeapSnapshotEdgeProxy.js:
(WebInspector.HeapSnapshotEdgeProxy.prototype.isPrivateSymbol):
Checks that the edge data does not begin with "PrivateSymbol".
* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype._populate):
Only add child nodes if they are not PrivateSymbol nodes.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (205826 => 205827)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-12 21:44:29 UTC (rev 205826)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-12 21:46:49 UTC (rev 205827)
@@ -1,3 +1,18 @@
+2016-09-12 Devin Rousso <dcrousso+web...@gmail.com>
+
+ Web Inspector: Hide ["PrivateSymbol.concatSlowPath"] and other PrivateSymbols from memory edges
+ https://bugs.webkit.org/show_bug.cgi?id=156763
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Proxies/HeapSnapshotEdgeProxy.js:
+ (WebInspector.HeapSnapshotEdgeProxy.prototype.isPrivateSymbol):
+ Checks that the edge data does not begin with "PrivateSymbol".
+
+ * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+ (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._populate):
+ Only add child nodes if they are not PrivateSymbol nodes.
+
2016-09-12 Matt Baker <mattba...@apple.com>
Web Inspector: Object.shallowEqual() should return false if object prototype chains differ
Modified: trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotEdgeProxy.js (205826 => 205827)
--- trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotEdgeProxy.js 2016-09-12 21:44:29 UTC (rev 205826)
+++ trunk/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotEdgeProxy.js 2016-09-12 21:46:49 UTC (rev 205827)
@@ -42,6 +42,14 @@
this.to = null;
}
+ isPrivateSymbol()
+ {
+ if (WebInspector.isDebugUIEnabled())
+ return false;
+
+ return typeof this.data ="" "string" && this.data.startsWith("PrivateSymbol");
+ }
+
// Static
static deserialize(objectId, serializedEdge)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js (205826 => 205827)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-09-12 21:44:29 UTC (rev 205826)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-09-12 21:46:49 UTC (rev 205827)
@@ -221,8 +221,12 @@
// FIXME: This should gracefully handle a node that references many objects.
- for (let instance of instances)
+ for (let instance of instances) {
+ if (instance.__edge && instance.__edge.isPrivateSymbol())
+ continue;
+
this.appendChild(new WebInspector.HeapSnapshotInstanceDataGridNode(instance, this._tree, instance.__edge, this._base || this));
+ }
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
