Title: [206585] trunk/Source/WTF
Revision
206585
Author
commit-qu...@webkit.org
Date
2016-09-29 10:08:28 -0700 (Thu, 29 Sep 2016)

Log Message

Unreviewed, rolling out r206563.
https://bugs.webkit.org/show_bug.cgi?id=162732

Caused stress/op_*.js.ftl-no-cjit tests to time out (Requested
by ryanhaddad on #webkit).

Reverted changeset:

"Re-enable StringView life-cycle checking."
https://bugs.webkit.org/show_bug.cgi?id=160384
http://trac.webkit.org/changeset/206563

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (206584 => 206585)


--- trunk/Source/WTF/ChangeLog	2016-09-29 15:47:00 UTC (rev 206584)
+++ trunk/Source/WTF/ChangeLog	2016-09-29 17:08:28 UTC (rev 206585)
@@ -1,3 +1,17 @@
+2016-09-29  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r206563.
+        https://bugs.webkit.org/show_bug.cgi?id=162732
+
+        Caused stress/op_*.js.ftl-no-cjit tests to time out (Requested
+        by ryanhaddad on #webkit).
+
+        Reverted changeset:
+
+        "Re-enable StringView life-cycle checking."
+        https://bugs.webkit.org/show_bug.cgi?id=160384
+        http://trac.webkit.org/changeset/206563
+
 2016-09-29  Fujii Hironori  <hironori.fu...@sony.com>
 
         Clang 3.9 reports a compilation warning about ENABLE_EXCEPTION_SCOPE_VERIFICATION

Modified: trunk/Source/WTF/wtf/text/StringView.h (206584 => 206585)


--- trunk/Source/WTF/wtf/text/StringView.h	2016-09-29 15:47:00 UTC (rev 206584)
+++ trunk/Source/WTF/wtf/text/StringView.h	2016-09-29 17:08:28 UTC (rev 206585)
@@ -36,7 +36,8 @@
 #include <wtf/text/StringCommon.h>
 
 // FIXME: Enabling the StringView lifetime checking causes the MSVC build to fail. Figure out why.
-#if defined(NDEBUG) || COMPILER(MSVC)
+// FIXME: Enable StringView lifetime checking once the underlying assertions have been fixed.
+#if defined(NDEBUG) || COMPILER(MSVC) || 1
 #define CHECK_STRINGVIEW_LIFETIME 0
 #else
 #define CHECK_STRINGVIEW_LIFETIME 1
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to