Title: [206629] trunk/Source/WebCore
Revision
206629
Author
rn...@webkit.org
Date
2016-09-29 19:04:07 -0700 (Thu, 29 Sep 2016)

Log Message

Editor::findStringAndScrollToVisible is unused
https://bugs.webkit.org/show_bug.cgi?id=162762

Reviewed by Simon Fraser.

Deleted the unused function.

* editing/Editor.cpp:
(WebCore::Editor::findStringAndScrollToVisible): Deleted.
* editing/Editor.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (206628 => 206629)


--- trunk/Source/WebCore/ChangeLog	2016-09-30 00:48:55 UTC (rev 206628)
+++ trunk/Source/WebCore/ChangeLog	2016-09-30 02:04:07 UTC (rev 206629)
@@ -1,3 +1,16 @@
+2016-09-29  Ryosuke Niwa  <rn...@webkit.org>
+
+        Editor::findStringAndScrollToVisible is unused
+        https://bugs.webkit.org/show_bug.cgi?id=162762
+
+        Reviewed by Simon Fraser.
+
+        Deleted the unused function.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::findStringAndScrollToVisible): Deleted.
+        * editing/Editor.h:
+
 2016-09-29  Jiewen Tan  <jiewen_...@apple.com>
 
         Expose CryptoKey to web workers

Modified: trunk/Source/WebCore/editing/Editor.cpp (206628 => 206629)


--- trunk/Source/WebCore/editing/Editor.cpp	2016-09-30 00:48:55 UTC (rev 206628)
+++ trunk/Source/WebCore/editing/Editor.cpp	2016-09-30 02:04:07 UTC (rev 206629)
@@ -3151,18 +3151,6 @@
     return true;
 }
 
-RefPtr<Range> Editor::findStringAndScrollToVisible(const String& target, Range* previousMatch, FindOptions options)
-{
-    RefPtr<Range> nextMatch = rangeOfString(target, previousMatch, options);
-    if (!nextMatch)
-        return nullptr;
-
-    nextMatch->firstNode()->renderer()->scrollRectToVisible(SelectionRevealMode::Reveal, nextMatch->absoluteBoundingBox(),
-        ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded);
-
-    return nextMatch;
-}
-
 RefPtr<Range> Editor::rangeOfString(const String& target, Range* referenceRange, FindOptions options)
 {
     if (target.isEmpty())

Modified: trunk/Source/WebCore/editing/Editor.h (206628 => 206629)


--- trunk/Source/WebCore/editing/Editor.h	2016-09-30 00:48:55 UTC (rev 206628)
+++ trunk/Source/WebCore/editing/Editor.h	2016-09-30 02:04:07 UTC (rev 206629)
@@ -372,7 +372,6 @@
     WEBCORE_EXPORT bool findString(const String&, FindOptions);
 
     RefPtr<Range> rangeOfString(const String&, Range*, FindOptions);
-    RefPtr<Range> findStringAndScrollToVisible(const String&, Range*, FindOptions);
 
     const VisibleSelection& mark() const; // Mark, to be used as emacs uses it.
     void setMark(const VisibleSelection&);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to