Title: [207394] trunk/Source/WebCore
- Revision
- 207394
- Author
- simon.fra...@apple.com
- Date
- 2016-10-16 11:59:31 -0700 (Sun, 16 Oct 2016)
Log Message
Implement serializer = { attribute }
https://bugs.webkit.org/show_bug.cgi?id=163466
Follow-up fix to die if "serializer {...}" lists an attribute not present
on the interface. I don't think this is testable with the current bindings tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateSerializerFunction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207393 => 207394)
--- trunk/Source/WebCore/ChangeLog 2016-10-16 18:47:05 UTC (rev 207393)
+++ trunk/Source/WebCore/ChangeLog 2016-10-16 18:59:31 UTC (rev 207394)
@@ -1,5 +1,16 @@
2016-10-16 Simon Fraser <simon.fra...@apple.com>
+ Implement serializer = { attribute }
+ https://bugs.webkit.org/show_bug.cgi?id=163466
+
+ Follow-up fix to die if "serializer {...}" lists an attribute not present
+ on the interface. I don't think this is testable with the current bindings tests.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateSerializerFunction):
+
+2016-10-16 Simon Fraser <simon.fra...@apple.com>
+
Add the "Geometry Interfaces" to features.json.
* features.json:
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207393 => 207394)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-16 18:47:05 UTC (rev 207393)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-16 18:59:31 UTC (rev 207394)
@@ -3984,12 +3984,16 @@
my @serializedAttributes = ();
foreach my $attribute_name (@{$interface->serializable->attributes}) {
+ my $found_attribute = 0;
foreach my $attribute (@{$interface->attributes}) {
if ($attribute_name eq $attribute->signature->name) {
push @serializedAttributes, $attribute;
+ $found_attribute = 1;
last;
}
}
+
+ die "Failed to find \"serializate\" attribute \"$attribute_name\" in $interfaceName" if !$found_attribute;
}
foreach my $attribute (@serializedAttributes) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
