- Revision
- 207588
- Author
- nael.ouedra...@crf.canon.fr
- Date
- 2016-10-20 00:26:55 -0700 (Thu, 20 Oct 2016)
Log Message
WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
https://bugs.webkit.org/show_bug.cgi?id=146232
Update MediaStreamTrackEvent IDL as per specification.
Source/WebCore:
Reviewed by Darin Adler.
No additional test required, rebase existings tests.
* Modules/mediastream/MediaStreamTrackEvent.idl:
LayoutTests:
No additional test required, rebase existings tests.
Reviewed by Darin Adler.
* fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
* fast/mediastream/MediaStreamTrackEvent-constructor.html: Remove
useless tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (207587 => 207588)
--- trunk/LayoutTests/ChangeLog 2016-10-20 06:43:59 UTC (rev 207587)
+++ trunk/LayoutTests/ChangeLog 2016-10-20 07:26:55 UTC (rev 207588)
@@ -1,3 +1,18 @@
+2016-10-20 Nael Ouedraogo <nael.ouedra...@crf.canon.fr>
+
+ WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
+ https://bugs.webkit.org/show_bug.cgi?id=146232
+
+ Update MediaStreamTrackEvent IDL as per specification.
+
+ No additional test required, rebase existings tests.
+
+ Reviewed by Darin Adler.
+
+ * fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
+ * fast/mediastream/MediaStreamTrackEvent-constructor.html: Remove
+ useless tests.
+
2016-10-19 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Media Controller: mute support
Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt (207587 => 207588)
--- trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt 2016-10-20 06:43:59 UTC (rev 207587)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt 2016-10-20 07:26:55 UTC (rev 207588)
@@ -9,14 +9,10 @@
PASS mediaStream.getVideoTracks()[0] is non-null.
*** No initializer passed ***
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').bubbles is false
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').cancelable is false
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').track is null
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent') threw exception TypeError: Not enough arguments.
*** Bubbles and cancelable true, track is missing ***
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).bubbles is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).cancelable is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track is null
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }) threw exception TypeError: Type error.
*** Bubbles and cancelable true, invalid track ***
PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }) threw exception TypeError: Type error.
Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html (207587 => 207588)
--- trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html 2016-10-20 06:43:59 UTC (rev 207587)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html 2016-10-20 07:26:55 UTC (rev 207588)
@@ -23,15 +23,11 @@
function testMediaStreamTrackEvent()
{
debug("<br>*** No initializer passed ***");
- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent').bubbles", "false");
- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent').cancelable", "false");
- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent').track");
-
+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent')", "TypeError");
+
debug("<br>*** Bubbles and cancelable true, track is missing ***");
- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).bubbles", "true");
- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).cancelable", "true");
- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track");
-
+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true })", "TypeError");
+
debug("<br>*** Bubbles and cancelable true, invalid track ***");
shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack })", "TypeError");
Modified: trunk/Source/WebCore/ChangeLog (207587 => 207588)
--- trunk/Source/WebCore/ChangeLog 2016-10-20 06:43:59 UTC (rev 207587)
+++ trunk/Source/WebCore/ChangeLog 2016-10-20 07:26:55 UTC (rev 207588)
@@ -1,3 +1,16 @@
+2016-10-20 Nael Ouedraogo <nael.ouedra...@crf.canon.fr>
+
+ WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
+ https://bugs.webkit.org/show_bug.cgi?id=146232
+
+ Update MediaStreamTrackEvent IDL as per specification.
+
+ Reviewed by Darin Adler.
+
+ No additional test required, rebase existings tests.
+
+ * Modules/mediastream/MediaStreamTrackEvent.idl:
+
2016-10-19 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Media Controller: mute support
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl (207587 => 207588)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl 2016-10-20 06:43:59 UTC (rev 207587)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl 2016-10-20 07:26:55 UTC (rev 207588)
@@ -24,12 +24,11 @@
[
Conditional=MEDIA_STREAM,
- Constructor(DOMString type, optional MediaStreamTrackEventInit eventInitDict),
+ Constructor(DOMString type, MediaStreamTrackEventInit eventInitDict),
] interface MediaStreamTrackEvent : Event {
- readonly attribute MediaStreamTrack? track;
+ readonly attribute MediaStreamTrack track;
};
dictionary MediaStreamTrackEventInit : EventInit {
- // FIXME: The specification says that this member should be required and non-nullable.
- MediaStreamTrack? track = null;
+ required MediaStreamTrack track;
};
