Title: [207636] trunk/Source/WebCore
- Revision
- 207636
- Author
- hy...@apple.com
- Date
- 2016-10-20 13:10:07 -0700 (Thu, 20 Oct 2016)
Log Message
[CSS Parser] Fix crash when parsing -webkit-margin-collapse
https://bugs.webkit.org/show_bug.cgi?id=163753
Reviewed by Dean Jackson.
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseShorthand):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207635 => 207636)
--- trunk/Source/WebCore/ChangeLog 2016-10-20 19:59:01 UTC (rev 207635)
+++ trunk/Source/WebCore/ChangeLog 2016-10-20 20:10:07 UTC (rev 207636)
@@ -1,3 +1,13 @@
+2016-10-20 Dave Hyatt <hy...@apple.com>
+
+ [CSS Parser] Fix crash when parsing -webkit-margin-collapse
+ https://bugs.webkit.org/show_bug.cgi?id=163753
+
+ Reviewed by Dean Jackson.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::CSSPropertyParser::parseShorthand):
+
2016-10-20 Chris Dumez <cdu...@apple.com>
Passing a number as the pixel parameter to texImage2D() doesn't thrown an exception
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (207635 => 207636)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-10-20 19:59:01 UTC (rev 207635)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-10-20 20:10:07 UTC (rev 207636)
@@ -4488,10 +4488,9 @@
CSSValueID id = m_range.consumeIncludingWhitespace().id();
if (!CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyWebkitMarginBeforeCollapse, id, m_context.mode))
return false;
- RefPtr<CSSValue> beforeCollapse = CSSValuePool::singleton().createIdentifierValue(id);
- addProperty(CSSPropertyWebkitMarginBeforeCollapse, CSSPropertyWebkitMarginCollapse, beforeCollapse.releaseNonNull(), important);
+ addProperty(CSSPropertyWebkitMarginBeforeCollapse, CSSPropertyWebkitMarginCollapse, CSSValuePool::singleton().createIdentifierValue(id), important);
if (m_range.atEnd()) {
- addProperty(CSSPropertyWebkitMarginAfterCollapse, CSSPropertyWebkitMarginCollapse, beforeCollapse.releaseNonNull(), important);
+ addProperty(CSSPropertyWebkitMarginAfterCollapse, CSSPropertyWebkitMarginCollapse, CSSValuePool::singleton().createIdentifierValue(id), important);
return true;
}
id = m_range.consumeIncludingWhitespace().id();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
