Title: [207738] trunk/Source/_javascript_Core
Revision
207738
Author
zandober...@gmail.com
Date
2016-10-24 00:05:20 -0700 (Mon, 24 Oct 2016)

Log Message

Unreviewed. Build fix for Clang and libstdc++ configurations.

* b3/testb3.cpp:
(JSC::B3::testAbsArgWithEffectfulDoubleConversion): Explicitly cast the
float-typed return value of fabs(float) to double in order to avoid
ambiguous calls to isIdentical().
(JSC::B3::testSqrtArgWithEffectfulDoubleConversion): Ditto for sqrt(float).

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (207737 => 207738)


--- trunk/Source/_javascript_Core/ChangeLog	2016-10-24 05:02:05 UTC (rev 207737)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-24 07:05:20 UTC (rev 207738)
@@ -1,3 +1,13 @@
+2016-10-23  Zan Dobersek  <zdober...@igalia.com>
+
+        Unreviewed. Build fix for Clang and libstdc++ configurations.
+
+        * b3/testb3.cpp:
+        (JSC::B3::testAbsArgWithEffectfulDoubleConversion): Explicitly cast the
+        float-typed return value of fabs(float) to double in order to avoid
+        ambiguous calls to isIdentical().
+        (JSC::B3::testSqrtArgWithEffectfulDoubleConversion): Ditto for sqrt(float).
+
 2016-10-22  Chris Dumez  <cdu...@apple.com>
 
         WebGLRenderingContextBase.bufferData() should use a union instead of overloading

Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (207737 => 207738)


--- trunk/Source/_javascript_Core/b3/testb3.cpp	2016-10-24 05:02:05 UTC (rev 207737)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp	2016-10-24 07:05:20 UTC (rev 207738)
@@ -3829,7 +3829,7 @@
     double effect = 0;
     int32_t resultValue = compileAndRun<int32_t>(proc, bitwise_cast<int32_t>(a), &effect);
     CHECK(isIdentical(resultValue, bitwise_cast<int32_t>(static_cast<float>(fabs(a)))));
-    CHECK(isIdentical(effect, fabs(a)));
+    CHECK(isIdentical(effect, static_cast<double>(fabs(a))));
 }
 
 void testCeilArg(double a)
@@ -4333,7 +4333,7 @@
     double effect = 0;
     int32_t resultValue = compileAndRun<int32_t>(proc, bitwise_cast<int32_t>(a), &effect);
     CHECK(isIdentical(resultValue, bitwise_cast<int32_t>(static_cast<float>(sqrt(a)))));
-    CHECK(isIdentical(effect, sqrt(a)));
+    CHECK(isIdentical(effect, static_cast<double>(sqrt(a))));
 }
 
 void testCompareTwoFloatToDouble(float a, float b)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to