Title: [207789] trunk/Source/_javascript_Core
- Revision
- 207789
- Author
- utatane....@gmail.com
- Date
- 2016-10-24 17:07:15 -0700 (Mon, 24 Oct 2016)
Log Message
[DOMJIT][DFG] CallDOM never writes Stack
https://bugs.webkit.org/show_bug.cgi?id=163926
Reviewed by Filip Pizlo and Saam Barati.
There is no way to write(Stack) in CallDOM.
This worst case (the most clobbering case) scenario
should be aligned to the one of Call, read(World) and write(Heap).
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207788 => 207789)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:05:24 UTC (rev 207788)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-25 00:07:15 UTC (rev 207789)
@@ -1,3 +1,17 @@
+2016-10-24 Yusuke Suzuki <utatane....@gmail.com>
+
+ [DOMJIT][DFG] CallDOM never writes Stack
+ https://bugs.webkit.org/show_bug.cgi?id=163926
+
+ Reviewed by Filip Pizlo and Saam Barati.
+
+ There is no way to write(Stack) in CallDOM.
+ This worst case (the most clobbering case) scenario
+ should be aligned to the one of Call, read(World) and write(Heap).
+
+ * dfg/DFGClobberize.h:
+ (JSC::DFG::clobberize):
+
2016-10-23 Yusuke Suzuki <utatane....@gmail.com>
[DOMJIT] Add a way for DOMJIT::Patchpoint to express effects
Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (207788 => 207789)
--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-10-25 00:05:24 UTC (rev 207788)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-10-25 00:07:15 UTC (rev 207789)
@@ -919,7 +919,7 @@
}
if (effect.writes) {
if (effect.writes == DOMJIT::HeapRange::top())
- write(World);
+ write(Heap);
else
write(AbstractHeap(DOMState, effect.writes.rawRepresentation()));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
