Title: [208319] trunk/Source/WebCore
Revision
208319
Author
simon.fra...@apple.com
Date
2016-11-02 19:43:15 -0700 (Wed, 02 Nov 2016)

Log Message

Followup after r208314.

The style created for reflections contains transforms and a mask, so needs to get explicit
z-index on it. This doesn't change rendering, since this layer has no children.

Fixes assertions in various reflection tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (208318 => 208319)


--- trunk/Source/WebCore/ChangeLog	2016-11-03 01:13:40 UTC (rev 208318)
+++ trunk/Source/WebCore/ChangeLog	2016-11-03 02:43:15 UTC (rev 208319)
@@ -1,5 +1,17 @@
 2016-11-02  Simon Fraser  <simon.fra...@apple.com>
 
+        Followup after r208314.
+
+        The style created for reflections contains transforms and a mask, so needs to get explicit
+        z-index on it. This doesn't change rendering, since this layer has no children.
+
+        Fixes assertions in various reflection tests.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::calculateClipRects):
+
+2016-11-02  Simon Fraser  <simon.fra...@apple.com>
+
         REGRESSION (r208025) GraphicsContext state stack assertions loading webkit.org
         https://bugs.webkit.org/show_bug.cgi?id=164350
         rdar://problem/29053414

Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (208318 => 208319)


--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2016-11-03 01:13:40 UTC (rev 208318)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2016-11-03 02:43:15 UTC (rev 208319)
@@ -6925,6 +6925,9 @@
 
     // Map in our mask.
     newStyle.setMaskBoxImage(renderer().style().boxReflect()->mask());
+    
+    // Style has transform and mask, so needs to be stacking context.
+    newStyle.setZIndex(0);
 
     return newStyle;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to