Title: [209436] trunk/Source/WebCore
- Revision
- 209436
- Author
- simon.fra...@apple.com
- Date
- 2016-12-06 16:46:23 -0800 (Tue, 06 Dec 2016)
Log Message
Fix editing text flakiness introduced in r209411
https://bugs.webkit.org/show_bug.cgi?id=165500
Reviewed by Dean Jackson.
The "insideFixed" out param was left uninitialized sometimes. This affected FrameSelection's
m_caretInsidePositionFixed, which caused problems in these tests.
Tested by editing tests in WK1.
* editing/htmlediting.cpp:
(WebCore::absoluteBoundsForLocalCaretRect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209435 => 209436)
--- trunk/Source/WebCore/ChangeLog 2016-12-07 00:46:02 UTC (rev 209435)
+++ trunk/Source/WebCore/ChangeLog 2016-12-07 00:46:23 UTC (rev 209436)
@@ -1,3 +1,18 @@
+2016-12-06 Simon Fraser <simon.fra...@apple.com>
+
+ Fix editing text flakiness introduced in r209411
+ https://bugs.webkit.org/show_bug.cgi?id=165500
+
+ Reviewed by Dean Jackson.
+
+ The "insideFixed" out param was left uninitialized sometimes. This affected FrameSelection's
+ m_caretInsidePositionFixed, which caused problems in these tests.
+
+ Tested by editing tests in WK1.
+
+ * editing/htmlediting.cpp:
+ (WebCore::absoluteBoundsForLocalCaretRect):
+
2016-12-06 Alexey Proskuryakov <a...@apple.com>
Correct SDKROOT values in xcconfig files
Modified: trunk/Source/WebCore/editing/htmlediting.cpp (209435 => 209436)
--- trunk/Source/WebCore/editing/htmlediting.cpp 2016-12-07 00:46:02 UTC (rev 209435)
+++ trunk/Source/WebCore/editing/htmlediting.cpp 2016-12-07 00:46:23 UTC (rev 209436)
@@ -1292,6 +1292,9 @@
IntRect absoluteBoundsForLocalCaretRect(RenderBlock* rendererForCaretPainting, const LayoutRect& rect, bool* insideFixed)
{
+ if (insideFixed)
+ *insideFixed = false;
+
if (!rendererForCaretPainting || rect.isEmpty())
return IntRect();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
