Title: [209439] trunk
- Revision
- 209439
- Author
- d...@apple.com
- Date
- 2016-12-06 17:23:54 -0800 (Tue, 06 Dec 2016)
Log Message
Apply styling to media documents with modern controls
https://bugs.webkit.org/show_bug.cgi?id=165499
<rdar://problems/29543847>
Reviewed by Antoine Quint.
Source/WebCore:
Existing MediaDocuments got styling from the injected style
sheet, which had rules for such documents. The modern media controls
use a scoped style rule, so we can't touch the document style. Instead,
inline the style directly from MediaDocument.
Test: media/modern-media-controls/media-documents/background-color-and-centering.html
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
LayoutTests:
Make sure that the small test video has the correct background,
and is not anchored to the top left of the page.
* media/modern-media-controls/media-documents/background-color-and-centering-expected.html: Added.
* media/modern-media-controls/media-documents/background-color-and-centering.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209438 => 209439)
--- trunk/LayoutTests/ChangeLog 2016-12-07 01:15:42 UTC (rev 209438)
+++ trunk/LayoutTests/ChangeLog 2016-12-07 01:23:54 UTC (rev 209439)
@@ -1,3 +1,17 @@
+2016-12-06 Dean Jackson <d...@apple.com>
+
+ Apply styling to media documents with modern controls
+ https://bugs.webkit.org/show_bug.cgi?id=165499
+ <rdar://problems/29543847>
+
+ Reviewed by Antoine Quint.
+
+ Make sure that the small test video has the correct background,
+ and is not anchored to the top left of the page.
+
+ * media/modern-media-controls/media-documents/background-color-and-centering-expected.html: Added.
+ * media/modern-media-controls/media-documents/background-color-and-centering.html: Added.
+
2016-12-05 Jiewen Tan <jiewen_...@apple.com>
[Part 1 of 2] Add support for SPKI format while doing SubtleCrypto.importKey/exportKey
Added: trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering-expected.html (0 => 209439)
--- trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering-expected.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering-expected.html 2016-12-07 01:23:54 UTC (rev 209439)
@@ -0,0 +1,2 @@
+<div style="width: 20px; height: 20px; background-color: rgb(38, 38, 38);"></div>
+
Property changes on: trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering-expected.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Added: trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html (0 => 209439)
--- trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html 2016-12-07 01:23:54 UTC (rev 209439)
@@ -0,0 +1,2 @@
+<!DOCTYPE html><!-- webkit-test-runner [ modernMediaControls=true ] -->
+<iframe src="" style="width: 360px; height: 400px; border: none; -webkit-clip-path: polygon(0px 0px, 20px 0px, 20px 20px, 0px 20px);"></iframe>
Property changes on: trunk/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (209438 => 209439)
--- trunk/Source/WebCore/ChangeLog 2016-12-07 01:15:42 UTC (rev 209438)
+++ trunk/Source/WebCore/ChangeLog 2016-12-07 01:23:54 UTC (rev 209439)
@@ -1,3 +1,21 @@
+2016-12-06 Dean Jackson <d...@apple.com>
+
+ Apply styling to media documents with modern controls
+ https://bugs.webkit.org/show_bug.cgi?id=165499
+ <rdar://problems/29543847>
+
+ Reviewed by Antoine Quint.
+
+ Existing MediaDocuments got styling from the injected style
+ sheet, which had rules for such documents. The modern media controls
+ use a scoped style rule, so we can't touch the document style. Instead,
+ inline the style directly from MediaDocument.
+
+ Test: media/modern-media-controls/media-documents/background-color-and-centering.html
+
+ * html/MediaDocument.cpp:
+ (WebCore::MediaDocumentParser::createDocumentStructure):
+
2016-12-06 Zalan Bujtas <za...@apple.com>
Move RenderElement::rendererForRootBackground to RenderView.
Modified: trunk/Source/WebCore/html/MediaDocument.cpp (209438 => 209439)
--- trunk/Source/WebCore/html/MediaDocument.cpp 2016-12-07 01:15:42 UTC (rev 209438)
+++ trunk/Source/WebCore/html/MediaDocument.cpp 2016-12-07 01:23:54 UTC (rev 209439)
@@ -98,7 +98,7 @@
auto metaElement = HTMLMetaElement::create(document);
metaElement->setAttributeWithoutSynchronization(nameAttr, AtomicString("viewport", AtomicString::ConstructFromLiteral));
- metaElement->setAttributeWithoutSynchronization(contentAttr, AtomicString("width=device-width,initial-scale=1,user-scalable=no", AtomicString::ConstructFromLiteral));
+ metaElement->setAttributeWithoutSynchronization(contentAttr, AtomicString("width=device-width,initial-scale=1", AtomicString::ConstructFromLiteral));
headElement->appendChild(metaElement);
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
