Log Message
Fixed a test failure seen in web-timing-minimal-performance-now.html https://bugs.webkit.org/show_bug.cgi?id=165542
Reviewed by Beth Dakin. This test was always slightly wrong, but it is much more likely to fail as of <https://trac.webkit.org/changeset/209462>. * fast/dom/Window/web-timing-minimal-performance-now.html: < is not a correct test for monotonicity. < tests for stricly increasing. <= is a correct test for monotonicity. All computer clocks have some granularity, so computer clocks are monotonic but not strictly increasing: you can sample the clock twice in the same tick.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209470 => 209471)
--- trunk/LayoutTests/ChangeLog 2016-12-07 20:40:43 UTC (rev 209470)
+++ trunk/LayoutTests/ChangeLog 2016-12-07 21:10:24 UTC (rev 209471)
@@ -1,3 +1,19 @@
+2016-12-07 Geoffrey Garen <gga...@apple.com>
+
+ Fixed a test failure seen in web-timing-minimal-performance-now.html
+ https://bugs.webkit.org/show_bug.cgi?id=165542
+
+ Reviewed by Beth Dakin.
+
+ This test was always slightly wrong, but it is much more likely to fail
+ as of <https://trac.webkit.org/changeset/209462>.
+
+ * fast/dom/Window/web-timing-minimal-performance-now.html: < is not a
+ correct test for monotonicity. < tests for stricly increasing. <= is a
+ correct test for monotonicity. All computer clocks have some granularity,
+ so computer clocks are monotonic but not strictly increasing: you can
+ sample the clock twice in the same tick.
+
2016-12-07 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Remove unused and mostly untested Page domain commands and events
Modified: trunk/LayoutTests/fast/dom/Window/web-timing-minimal-performance-now.html (209470 => 209471)
--- trunk/LayoutTests/fast/dom/Window/web-timing-minimal-performance-now.html 2016-12-07 20:40:43 UTC (rev 209470)
+++ trunk/LayoutTests/fast/dom/Window/web-timing-minimal-performance-now.html 2016-12-07 21:10:24 UTC (rev 209471)
@@ -10,7 +10,7 @@
function checkTimestamp(previousTimestamp) {
currentTimestamp = performance.now();
- isMonotonicClock = previousTimestamp < currentTimestamp;
+ isMonotonicClock = previousTimestamp <= currentTimestamp;
if (isMonotonicClock)
setTimeout('checkTimestamp(currentTimestamp)', 0);
}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
