Diff
Modified: trunk/LayoutTests/ChangeLog (209523 => 209524)
--- trunk/LayoutTests/ChangeLog 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 06:14:07 UTC (rev 209524)
@@ -1,3 +1,22 @@
+2016-12-07 Dave Hyatt <hy...@apple.com>
+
+ [CSS Parser] Unskip calc() tests
+ https://bugs.webkit.org/show_bug.cgi?id=165583
+
+ Reviewed by Zalan Bujtas.
+
+ * TestExpectations:
+ * fast/css/flex-shrink-calculated-value-expected.txt:
+ * fast/css/flex-shrink-calculated-value.html:
+ * fast/css/negative-calc-values-expected.txt:
+ * fast/css/negative-calc-values.html:
+ * fast/css/text-shadow-calc-value-expected.txt:
+ * fast/css/text-shadow-calc-value.html:
+ * fast/css/webkit-line-clamp-calculated-value-expected.txt:
+ * fast/css/webkit-line-clamp-calculated-value.html:
+ * fast/css/z-index-calculated-value-expected.txt:
+ * fast/css/z-index-calculated-value.html:
+
2016-12-07 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Tracks panel does not display in the right location in fullscreen and cannot be dismissed
Modified: trunk/LayoutTests/TestExpectations (209523 => 209524)
--- trunk/LayoutTests/TestExpectations 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/TestExpectations 2016-12-08 06:14:07 UTC (rev 209524)
@@ -1025,9 +1025,6 @@
webkit.org/b/165195 fast/css/font-family-parse-keyword.html [ Pass Failure ]
webkit.org/b/165195 fast/css/variables/custom-property-dynamic-update.html [ Skip ]
webkit.org/b/165195 transitions/transitions-parsing.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/flex-shrink-calculated-value.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/webkit-line-clamp-calculated-value.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/z-index-calculated-value.html [ Pass Failure ]
webkit.org/b/165195 fast/css/aspect-ratio-parsing-tests.html [ Pass Failure ]
webkit.org/b/165195 fast/css-grid-layout/grid-auto-flow-get-set.html [ Pass Failure ]
webkit.org/b/165195 fast/css-grid-layout/grid-columns-rows-get-set.html [ Pass Failure ]
@@ -1035,8 +1032,6 @@
webkit.org/b/165195 fast/masking/parsing-mask.html [ Pass Failure ]
webkit.org/b/165195 fast/css/font-calculated-value.html [ Pass Failure ]
webkit.org/b/165195 fast/css/font-shorthand.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/negative-calc-values.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/text-shadow-calc-value.html [ Pass Failure ]
webkit.org/b/165195 fast/shadow-dom/slotted-pseudo-element-css-text.html [ Pass Failure ]
# The following tests match Blink/Chrome, but we're not sure yet what to do with them when the
Modified: trunk/LayoutTests/fast/css/flex-shrink-calculated-value-expected.txt (209523 => 209524)
--- trunk/LayoutTests/fast/css/flex-shrink-calculated-value-expected.txt 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/flex-shrink-calculated-value-expected.txt 2016-12-08 06:14:07 UTC (rev 209524)
@@ -5,7 +5,7 @@
PASS testDiv.style['flex-shrink'] is ""
testDiv.style['flex-shrink'] = 'calc(2 * 3)'
-PASS testDiv.style['flex-shrink'] is "calc(6)"
+PASS testDiv.style['flex-shrink'] is "6"
PASS window.getComputedStyle(testDiv).getPropertyValue('flex-shrink') is "6"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/css/flex-shrink-calculated-value.html (209523 => 209524)
--- trunk/LayoutTests/fast/css/flex-shrink-calculated-value.html 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/flex-shrink-calculated-value.html 2016-12-08 06:14:07 UTC (rev 209524)
@@ -9,7 +9,7 @@
shouldBeEmptyString("testDiv.style['flex-shrink']");
evalAndLog("testDiv.style['flex-shrink'] = 'calc(2 * 3)'");
-shouldBeEqualToString("testDiv.style['flex-shrink']", "calc(6)");
+shouldBeEqualToString("testDiv.style['flex-shrink']", "6");
shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('flex-shrink')", "6");
</script>
Modified: trunk/LayoutTests/fast/css/negative-calc-values-expected.txt (209523 => 209524)
--- trunk/LayoutTests/fast/css/negative-calc-values-expected.txt 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/negative-calc-values-expected.txt 2016-12-08 06:14:07 UTC (rev 209524)
@@ -18,8 +18,8 @@
PASS window.getComputedStyle(testDiv).getPropertyValue('line-height') is "0px"
testPre.style['tab-size'] = '8'
testPre.style['tab-size'] = 'calc(2 - 4)'
-PASS testPre.style['tab-size'] is "calc(-2)"
-PASS window.getComputedStyle(testPre).getPropertyValue('tab-size') is "0"
+PASS testPre.style['tab-size'] is "8"
+PASS window.getComputedStyle(testPre).getPropertyValue('tab-size') is "8"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/css/negative-calc-values.html (209523 => 209524)
--- trunk/LayoutTests/fast/css/negative-calc-values.html 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/negative-calc-values.html 2016-12-08 06:14:07 UTC (rev 209524)
@@ -28,8 +28,8 @@
evalAndLog("testPre.style['tab-size'] = '8'");
evalAndLog("testPre.style['tab-size'] = 'calc(2 - 4)'");
-shouldBeEqualToString("testPre.style['tab-size']", "calc(-2)");
-shouldBeEqualToString("window.getComputedStyle(testPre).getPropertyValue('tab-size')", "0");
+shouldBeEqualToString("testPre.style['tab-size']", "8");
+shouldBeEqualToString("window.getComputedStyle(testPre).getPropertyValue('tab-size')", "8");
</script>
<script src=""
Modified: trunk/LayoutTests/fast/css/text-shadow-calc-value-expected.txt (209523 => 209524)
--- trunk/LayoutTests/fast/css/text-shadow-calc-value-expected.txt 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/text-shadow-calc-value-expected.txt 2016-12-08 06:14:07 UTC (rev 209524)
@@ -11,8 +11,8 @@
PASS testDiv.style['text-shadow'] is "rgb(255, 255, 255) calc(-3px) calc(-6px) calc(9px)"
PASS window.getComputedStyle(testDiv).getPropertyValue('text-shadow') is "rgb(255, 255, 255) -3px -6px 9px"
testDiv.style['text-shadow'] = 'calc(1 * 3px) calc(2 * 3px) calc(-3 * 3px) rgb(255, 255, 255)'
-PASS testDiv.style['text-shadow'] is "rgb(255, 255, 255) calc(3px) calc(6px) calc(-9px)"
-PASS window.getComputedStyle(testDiv).getPropertyValue('text-shadow') is "rgb(255, 255, 255) 3px 6px 0px"
+PASS testDiv.style['text-shadow'] is "rgb(255, 255, 255) calc(-3px) calc(-6px) calc(9px)"
+PASS window.getComputedStyle(testDiv).getPropertyValue('text-shadow') is "rgb(255, 255, 255) -3px -6px 9px"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/css/text-shadow-calc-value.html (209523 => 209524)
--- trunk/LayoutTests/fast/css/text-shadow-calc-value.html 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/text-shadow-calc-value.html 2016-12-08 06:14:07 UTC (rev 209524)
@@ -20,8 +20,8 @@
// Negative blur-radius is not allowed so it should become 0.
evalAndLog("testDiv.style['text-shadow'] = 'calc(1 * 3px) calc(2 * 3px) calc(-3 * 3px) rgb(255, 255, 255)'");
// text-shadow should not be updated.
-shouldBeEqualToString("testDiv.style['text-shadow']", "rgb(255, 255, 255) calc(3px) calc(6px) calc(-9px)");
-shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('text-shadow')", "rgb(255, 255, 255) 3px 6px 0px")
+shouldBeEqualToString("testDiv.style['text-shadow']", "rgb(255, 255, 255) calc(-3px) calc(-6px) calc(9px)");
+shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('text-shadow')", "rgb(255, 255, 255) -3px -6px 9px")
</script>
<script src=""
Modified: trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value-expected.txt (209523 => 209524)
--- trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value-expected.txt 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value-expected.txt 2016-12-08 06:14:07 UTC (rev 209524)
@@ -8,7 +8,7 @@
PASS testDiv.style['-webkit-line-clamp'] is "calc(20%)"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-line-clamp') is "20%"
testDiv.style['-webkit-line-clamp'] = 'calc(2 * 3)'
-PASS testDiv.style['-webkit-line-clamp'] is "calc(6)"
+PASS testDiv.style['-webkit-line-clamp'] is "6"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-line-clamp') is "6"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value.html (209523 => 209524)
--- trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value.html 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/webkit-line-clamp-calculated-value.html 2016-12-08 06:14:07 UTC (rev 209524)
@@ -12,7 +12,7 @@
shouldBeEqualToString("testDiv.style['-webkit-line-clamp']", "calc(20%)");
shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('-webkit-line-clamp')", "20%");
evalAndLog("testDiv.style['-webkit-line-clamp'] = 'calc(2 * 3)'");
-shouldBeEqualToString("testDiv.style['-webkit-line-clamp']", "calc(6)");
+shouldBeEqualToString("testDiv.style['-webkit-line-clamp']", "6");
shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('-webkit-line-clamp')", "6");
</script>
Modified: trunk/LayoutTests/fast/css/z-index-calculated-value-expected.txt (209523 => 209524)
--- trunk/LayoutTests/fast/css/z-index-calculated-value-expected.txt 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/z-index-calculated-value-expected.txt 2016-12-08 06:14:07 UTC (rev 209524)
@@ -5,7 +5,7 @@
PASS testDiv.style['z-index'] is ""
testDiv.style['z-index'] = 'calc(-2 * 3)'
-PASS testDiv.style['z-index'] is "calc(-6)"
+PASS testDiv.style['z-index'] is "-6"
PASS window.getComputedStyle(testDiv).getPropertyValue('z-index') is "-6"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/css/z-index-calculated-value.html (209523 => 209524)
--- trunk/LayoutTests/fast/css/z-index-calculated-value.html 2016-12-08 05:51:05 UTC (rev 209523)
+++ trunk/LayoutTests/fast/css/z-index-calculated-value.html 2016-12-08 06:14:07 UTC (rev 209524)
@@ -9,7 +9,7 @@
shouldBeEmptyString("testDiv.style['z-index']");
evalAndLog("testDiv.style['z-index'] = 'calc(-2 * 3)'");
-shouldBeEqualToString("testDiv.style['z-index']", "calc(-6)");
+shouldBeEqualToString("testDiv.style['z-index']", "-6");
shouldBeEqualToString("window.getComputedStyle(testDiv).getPropertyValue('z-index')", "-6");
</script>
