Title: [209621] trunk/Source/_javascript_Core
- Revision
- 209621
- Author
- fpi...@apple.com
- Date
- 2016-12-09 11:48:12 -0800 (Fri, 09 Dec 2016)
Log Message
JSSegmentedVariableObject should keep its state private
Rubber stamped by Michael Saboff.
Its state fields were protected for no reason. They really should be private because
you have to know to obey a particular concurrency protocol when accessing them.
* runtime/JSSegmentedVariableObject.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209620 => 209621)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-09 19:42:43 UTC (rev 209620)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-09 19:48:12 UTC (rev 209621)
@@ -1,3 +1,14 @@
+2016-12-09 Filip Pizlo <fpi...@apple.com>
+
+ JSSegmentedVariableObject should keep its state private
+
+ Rubber stamped by Michael Saboff.
+
+ Its state fields were protected for no reason. They really should be private because
+ you have to know to obey a particular concurrency protocol when accessing them.
+
+ * runtime/JSSegmentedVariableObject.h:
+
2016-12-09 Csaba Osztrogonác <o...@webkit.org>
Unreviewed ARM buildfix after 209570.
Modified: trunk/Source/_javascript_Core/runtime/JSSegmentedVariableObject.h (209620 => 209621)
--- trunk/Source/_javascript_Core/runtime/JSSegmentedVariableObject.h 2016-12-09 19:42:43 UTC (rev 209620)
+++ trunk/Source/_javascript_Core/runtime/JSSegmentedVariableObject.h 2016-12-09 19:48:12 UTC (rev 209621)
@@ -96,6 +96,7 @@
setSymbolTable(vm, SymbolTable::create(vm));
}
+private:
SegmentedVector<WriteBarrier<Unknown>, 16> m_variables;
ConcurrentJSLock m_lock;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
