Title: [209998] trunk/Source/_javascript_Core
- Revision
- 209998
- Author
- commit-qu...@webkit.org
- Date
- 2016-12-19 14:45:02 -0800 (Mon, 19 Dec 2016)
Log Message
Web Inspector: Assertion seen in InspectorDebuggerAgent::refAsyncCallData with Inspector open
https://bugs.webkit.org/show_bug.cgi?id=166034
<rdar://problem/29554366>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-12-19
Reviewed by Brian Burg.
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::refAsyncCallData):
Remove assertion. This assert can happen if the currently executing callback
was just explicitly cancelled by script. Existing code already handles if
no async data was found for the given identifier.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209997 => 209998)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-19 22:06:25 UTC (rev 209997)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-19 22:45:02 UTC (rev 209998)
@@ -1,3 +1,17 @@
+2016-12-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Assertion seen in InspectorDebuggerAgent::refAsyncCallData with Inspector open
+ https://bugs.webkit.org/show_bug.cgi?id=166034
+ <rdar://problem/29554366>
+
+ Reviewed by Brian Burg.
+
+ * inspector/agents/InspectorDebuggerAgent.cpp:
+ (Inspector::InspectorDebuggerAgent::refAsyncCallData):
+ Remove assertion. This assert can happen if the currently executing callback
+ was just explicitly cancelled by script. Existing code already handles if
+ no async data was found for the given identifier.
+
2016-12-18 Saam Barati <sbar...@apple.com>
WebAssembly: Implement the WebAssembly.compile and WebAssembly.validate
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp (209997 => 209998)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp 2016-12-19 22:06:25 UTC (rev 209997)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp 2016-12-19 22:45:02 UTC (rev 209998)
@@ -1142,7 +1142,6 @@
void InspectorDebuggerAgent::refAsyncCallData(const AsyncCallIdentifier& identifier)
{
auto iterator = m_asyncCallIdentifierToData.find(identifier);
- ASSERT(iterator != m_asyncCallIdentifierToData.end());
if (iterator == m_asyncCallIdentifierToData.end())
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
