Title: [210423] trunk
Revision
210423
Author
simon.fra...@apple.com
Date
2017-01-05 17:55:07 -0800 (Thu, 05 Jan 2017)

Log Message

Radio buttons have a fixed border radius making them look square when resized
https://bugs.webkit.org/show_bug.cgi?id=148676
Source/WebCore:

rdar://problem/29889892

Reviewed by Tim Horton.

Change the 8px border-radius of iOS radio buttons to 50% so they remain circular
when the page overrides the size.

Test: fast/forms/ios/large-radio-button-is-round.html

* css/html.css:
(#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS):

LayoutTests:

Reviewed by Tim Horton.

* fast/forms/ios/large-radio-button-is-round-expected.html: Added.
* fast/forms/ios/large-radio-button-is-round.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (210422 => 210423)


--- trunk/LayoutTests/ChangeLog	2017-01-06 01:49:39 UTC (rev 210422)
+++ trunk/LayoutTests/ChangeLog	2017-01-06 01:55:07 UTC (rev 210423)
@@ -1,3 +1,13 @@
+2017-01-05  Simon Fraser  <simon.fra...@apple.com>
+
+        Radio buttons have a fixed border radius making them look square when resized
+        https://bugs.webkit.org/show_bug.cgi?id=148676
+
+        Reviewed by Tim Horton.
+
+        * fast/forms/ios/large-radio-button-is-round-expected.html: Added.
+        * fast/forms/ios/large-radio-button-is-round.html: Added.
+
 2017-01-05  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         Carets can split up marriages and families

Added: trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round-expected.html (0 => 210423)


--- trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round-expected.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round-expected.html	2017-01-06 01:55:07 UTC (rev 210423)
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+
+<html>
+<head>
+</head>
+<body>
+<p>The radio button below should be entirely clipped out</p>
+</body>
+</html>

Added: trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round.html (0 => 210423)


--- trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/large-radio-button-is-round.html	2017-01-06 01:55:07 UTC (rev 210423)
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+
+<html>
+<head>
+    <style>
+        input {
+            -webkit-clip-path: inset(0 90% 90% 0);
+        }
+    </style>
+</head>
+<body>
+<p>The radio button below should be entirely clipped out</p>
+<input type="radio" checked style="width:500px;height:500px;">
+</body>
+</html>

Modified: trunk/Source/WebCore/ChangeLog (210422 => 210423)


--- trunk/Source/WebCore/ChangeLog	2017-01-06 01:49:39 UTC (rev 210422)
+++ trunk/Source/WebCore/ChangeLog	2017-01-06 01:55:07 UTC (rev 210423)
@@ -1,3 +1,19 @@
+2017-01-05  Simon Fraser  <simon.fra...@apple.com>
+
+        Radio buttons have a fixed border radius making them look square when resized
+        https://bugs.webkit.org/show_bug.cgi?id=148676
+        rdar://problem/29889892
+
+        Reviewed by Tim Horton.
+
+        Change the 8px border-radius of iOS radio buttons to 50% so they remain circular
+        when the page overrides the size.
+
+        Test: fast/forms/ios/large-radio-button-is-round.html
+
+        * css/html.css:
+        (#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS):
+
 2017-01-05  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         CoreText variation axis identifiers don't work with 64-bit numbers

Modified: trunk/Source/WebCore/css/html.css (210422 => 210423)


--- trunk/Source/WebCore/css/html.css	2017-01-06 01:49:39 UTC (rev 210422)
+++ trunk/Source/WebCore/css/html.css	2017-01-06 01:55:07 UTC (rev 210423)
@@ -795,7 +795,7 @@
 #if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS
 input[type="radio"] {
     -webkit-appearance: radio;
-    border-radius: 8px;
+    border-radius: 50%;
     width: 16px;
     height: 16px;
     padding: 0px;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to