Title: [210692] trunk/Source/WebCore
- Revision
- 210692
- Author
- ryanhad...@apple.com
- Date
- 2017-01-12 17:42:59 -0800 (Thu, 12 Jan 2017)
Log Message
Unreviewed, rolling out r210680.
This change caused LayoutTest timeouts and assertion failures.
Reverted changeset:
"Use GenericEventQueue rather than callOnMainThread to
schedule events in AudioScheduledSourceNode."
https://bugs.webkit.org/show_bug.cgi?id=166983
http://trac.webkit.org/changeset/210680
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210691 => 210692)
--- trunk/Source/WebCore/ChangeLog 2017-01-13 01:30:02 UTC (rev 210691)
+++ trunk/Source/WebCore/ChangeLog 2017-01-13 01:42:59 UTC (rev 210692)
@@ -1,3 +1,16 @@
+2017-01-12 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r210680.
+
+ This change caused LayoutTest timeouts and assertion failures.
+
+ Reverted changeset:
+
+ "Use GenericEventQueue rather than callOnMainThread to
+ schedule events in AudioScheduledSourceNode."
+ https://bugs.webkit.org/show_bug.cgi?id=166983
+ http://trac.webkit.org/changeset/210680
+
2017-01-12 Chris Dumez <cdu...@apple.com>
[iOS] HTML form validation popover sometimes does not go away
Modified: trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp (210691 => 210692)
--- trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2017-01-13 01:30:02 UTC (rev 210691)
+++ trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2017-01-13 01:42:59 UTC (rev 210692)
@@ -47,7 +47,6 @@
AudioScheduledSourceNode::AudioScheduledSourceNode(AudioContext& context, float sampleRate)
: AudioNode(context, sampleRate)
, m_endTime(UnknownTime)
- , m_eventQueue(*this)
{
}
@@ -167,8 +166,11 @@
context().decrementActiveSourceCount();
}
- if (m_hasEndedListener)
- m_eventQueue.enqueueEvent(Event::create(eventNames().endedEvent, false, false));
+ if (m_hasEndedListener) {
+ callOnMainThread([this] {
+ dispatchEvent(Event::create(eventNames().endedEvent, false, false));
+ });
+ }
}
bool AudioScheduledSourceNode::addEventListener(const AtomicString& eventType, Ref<EventListener>&& listener, const AddEventListenerOptions& options)
Modified: trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h (210691 => 210692)
--- trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2017-01-13 01:30:02 UTC (rev 210691)
+++ trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2017-01-13 01:42:59 UTC (rev 210692)
@@ -29,7 +29,6 @@
#pragma once
#include "AudioNode.h"
-#include "GenericEventQueue.h"
namespace WebCore {
@@ -84,7 +83,6 @@
double m_endTime; // in seconds
bool m_hasEndedListener { false };
- GenericEventQueue m_eventQueue;
static const double UnknownTime;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
