Title: [210736] trunk/Tools
- Revision
- 210736
- Author
- utatane....@gmail.com
- Date
- 2017-01-13 11:00:29 -0800 (Fri, 13 Jan 2017)
Log Message
run-jsc-benchmarks' echo should have -e option
https://bugs.webkit.org/show_bug.cgi?id=167009
Reviewed by Sam Weinig.
echo requires `-e` option to use escape sequence.
Without it, in some environment (in my Fedora 25), the escape sequence is not
recognized and just dumped as `\c` etc.
* Scripts/run-jsc-benchmarks:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (210735 => 210736)
--- trunk/Tools/ChangeLog 2017-01-13 18:30:09 UTC (rev 210735)
+++ trunk/Tools/ChangeLog 2017-01-13 19:00:29 UTC (rev 210736)
@@ -1,3 +1,16 @@
+2017-01-13 Yusuke Suzuki <utatane....@gmail.com>
+
+ run-jsc-benchmarks' echo should have -e option
+ https://bugs.webkit.org/show_bug.cgi?id=167009
+
+ Reviewed by Sam Weinig.
+
+ echo requires `-e` option to use escape sequence.
+ Without it, in some environment (in my Fedora 25), the escape sequence is not
+ recognized and just dumped as `\c` etc.
+
+ * Scripts/run-jsc-benchmarks:
+
2017-01-12 Chris Dumez <cdu...@apple.com>
Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
Modified: trunk/Tools/Scripts/run-jsc-benchmarks (210735 => 210736)
--- trunk/Tools/Scripts/run-jsc-benchmarks 2017-01-13 18:30:09 UTC (rev 210735)
+++ trunk/Tools/Scripts/run-jsc-benchmarks 2017-01-13 19:00:29 UTC (rev 210736)
@@ -3283,10 +3283,10 @@
if $prepare
File.open("#{BENCH_DATA_PATH}/runscript", "w") {
| file |
- file.puts "echo \"HOSTNAME:\\c\""
+ file.puts "echo -e \"HOSTNAME:\\c\""
file.puts "hostname"
file.puts "echo"
- file.puts "echo \"HARDWARE:\\c\""
+ file.puts "echo -e \"HARDWARE:\\c\""
file.puts "/usr/sbin/sysctl hw.model"
file.puts "echo"
file.puts "set -e"
@@ -3296,14 +3296,14 @@
if $verbosity == 0 and not $silent
text1 = lpad(idx.to_s,$runPlans.size.to_s.size)+"/"+$runPlans.size.to_s
text2 = plan.to_s
- file.puts("echo " + Shellwords.shellescape("\r#{text1} #{rpad(text2,$planpad)}") + "\"\\c\" 1>&2")
- file.puts("echo " + Shellwords.shellescape("\r#{text1} #{text2}") + "\"\\c\" 1>&2")
+ file.puts("echo -e " + Shellwords.shellescape("\r#{text1} #{rpad(text2,$planpad)}") + "\"\\c\" 1>&2")
+ file.puts("echo -e " + Shellwords.shellescape("\r#{text1} #{text2}") + "\"\\c\" 1>&2")
end
plan.emitRunCode
}
if $verbosity == 0 and not $silent
- file.puts("echo " + Shellwords.shellescape("\r#{$runPlans.size}/#{$runPlans.size} #{' '*($suitepad+1+$benchpad+1+$vmpad)}") + "\"\\c\" 1>&2")
- file.puts("echo " + Shellwords.shellescape("\r#{$runPlans.size}/#{$runPlans.size}") + " 1>&2")
+ file.puts("echo -e " + Shellwords.shellescape("\r#{$runPlans.size}/#{$runPlans.size} #{' '*($suitepad+1+$benchpad+1+$vmpad)}") + "\"\\c\" 1>&2")
+ file.puts("echo -e " + Shellwords.shellescape("\r#{$runPlans.size}/#{$runPlans.size}") + " 1>&2")
end
}
end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
