Title: [210892] trunk/Source/WebKit2
Revision
210892
Author
ander...@apple.com
Date
2017-01-18 15:23:06 -0800 (Wed, 18 Jan 2017)

Log Message

Add instrumentation for when we fail to receive a message
https://bugs.webkit.org/show_bug.cgi?id=167179

Reviewed by Alexey Proskuryakov.

This will help us diagnose what the error from mach_msg is.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::readFromMachPort):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (210891 => 210892)


--- trunk/Source/WebKit2/ChangeLog	2017-01-18 22:53:39 UTC (rev 210891)
+++ trunk/Source/WebKit2/ChangeLog	2017-01-18 23:23:06 UTC (rev 210892)
@@ -1,3 +1,15 @@
+2017-01-18  Anders Carlsson  <ander...@apple.com>
+
+        Add instrumentation for when we fail to receive a message
+        https://bugs.webkit.org/show_bug.cgi?id=167179
+
+        Reviewed by Alexey Proskuryakov.
+
+        This will help us diagnose what the error from mach_msg is.
+
+        * Platform/IPC/mac/ConnectionMac.mm:
+        (IPC::readFromMachPort):
+
 2017-01-18  Alex Christensen  <achristen...@webkit.org>
 
         Fix CFURLConnection build on Mac

Modified: trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm (210891 => 210892)


--- trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2017-01-18 22:53:39 UTC (rev 210891)
+++ trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2017-01-18 23:23:06 UTC (rev 210892)
@@ -497,6 +497,9 @@
     }
 
     if (kr != MACH_MSG_SUCCESS) {
+#if !ASSERT_DISABLED
+        WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg", kr]);
+#endif
         ASSERT_NOT_REACHED();
         return 0;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to