[webkit-changes] [210932] trunk

Thu, 19 Jan 2017 11:24:02 -0800

Title: [210932] trunk
Revision
210932
Author
mmaxfi...@apple.com
Date
2017-01-19 11:24:12 -0800 (Thu, 19 Jan 2017)

Log Message

[Cocoa] Variation fonts are erroneously disabled on iOS
https://bugs.webkit.org/show_bug.cgi?id=167172

Reviewed by Simon Fraser.

OpenSource builders don't seem to understand sdk=embedded*.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (210931 => 210932)


--- trunk/Source/_javascript_Core/ChangeLog	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-01-19 19:24:12 UTC (rev 210932)
@@ -1,3 +1,14 @@
+2017-01-19  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Variation fonts are erroneously disabled on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=167172
+
+        Reviewed by Simon Fraser.
+
+        OpenSource builders don't seem to understand sdk=embedded*.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-01-19  Skachkov Oleksandr  <gskach...@gmail.com>
 
         "this" missing after await in async arrow function

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (210931 => 210932)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-01-19 19:24:12 UTC (rev 210932)
@@ -39,7 +39,7 @@
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING;
 
-ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
+ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
 ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY[sdk=iphoneos9*] = ;
@@ -205,7 +205,7 @@
 ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT;
 ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT;
 
-ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
+ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
 ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ;

Modified: trunk/Source/WebCore/ChangeLog (210931 => 210932)


--- trunk/Source/WebCore/ChangeLog	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebCore/ChangeLog	2017-01-19 19:24:12 UTC (rev 210932)
@@ -1,3 +1,14 @@
+2017-01-19  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Variation fonts are erroneously disabled on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=167172
+
+        Reviewed by Simon Fraser.
+
+        OpenSource builders don't seem to understand sdk=embedded*.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-01-19  Ryan Haddad  <ryanhad...@apple.com>
 
         Rebaseline bindings tests after r210918.

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (210931 => 210932)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-01-19 19:24:12 UTC (rev 210932)
@@ -39,7 +39,7 @@
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING;
 
-ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
+ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
 ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY[sdk=iphoneos9*] = ;
@@ -205,7 +205,7 @@
 ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT;
 ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT;
 
-ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
+ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
 ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ;

Modified: trunk/Source/WebKit/mac/ChangeLog (210931 => 210932)


--- trunk/Source/WebKit/mac/ChangeLog	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-01-19 19:24:12 UTC (rev 210932)
@@ -1,3 +1,14 @@
+2017-01-19  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Variation fonts are erroneously disabled on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=167172
+
+        Reviewed by Simon Fraser.
+
+        OpenSource builders don't seem to understand sdk=embedded*.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-01-19  Andreas Kling  <akl...@apple.com>
 
         ScriptExecutionContext::topOrigin() should return a reference.

Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (210931 => 210932)


--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2017-01-19 19:24:12 UTC (rev 210932)
@@ -39,7 +39,7 @@
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING;
 
-ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
+ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
 ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY[sdk=iphoneos9*] = ;
@@ -205,7 +205,7 @@
 ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT;
 ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT;
 
-ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
+ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
 ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ;

Modified: trunk/Source/WebKit2/ChangeLog (210931 => 210932)


--- trunk/Source/WebKit2/ChangeLog	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebKit2/ChangeLog	2017-01-19 19:24:12 UTC (rev 210932)
@@ -1,3 +1,14 @@
+2017-01-19  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Variation fonts are erroneously disabled on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=167172
+
+        Reviewed by Simon Fraser.
+
+        OpenSource builders don't seem to understand sdk=embedded*.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-01-18  Anders Carlsson  <ander...@apple.com>
 
         Install WebKit.apinotes with the public headers of WebKit framework

Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (210931 => 210932)


--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2017-01-19 19:24:12 UTC (rev 210932)
@@ -39,7 +39,7 @@
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING;
 
-ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
+ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
 ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY[sdk=iphoneos9*] = ;
@@ -205,7 +205,7 @@
 ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT;
 ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT;
 
-ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
+ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
 ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ;

Modified: trunk/Tools/ChangeLog (210931 => 210932)


--- trunk/Tools/ChangeLog	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Tools/ChangeLog	2017-01-19 19:24:12 UTC (rev 210932)
@@ -1,3 +1,14 @@
+2017-01-19  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Variation fonts are erroneously disabled on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=167172
+
+        Reviewed by Simon Fraser.
+
+        OpenSource builders don't seem to understand sdk=embedded*.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-01-19  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Unreviewed. Fix GTK+ unit tests failing since r210531.

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (210931 => 210932)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-01-19 19:16:22 UTC (rev 210931)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-01-19 19:24:12 UTC (rev 210932)
@@ -39,7 +39,7 @@
 ENABLE_ACCELERATED_2D_CANVAS = ;
 ENABLE_ACCELERATED_OVERFLOW_SCROLLING[sdk=iphone*] = ENABLE_ACCELERATED_OVERFLOW_SCROLLING;
 
-ENABLE_APPLE_PAY[sdk=embedded*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
+ENABLE_APPLE_PAY[sdk=iphone*] = $(ENABLE_APPLE_PAY_$(PLATFORM_NAME));
 ENABLE_APPLE_PAY_iphoneos = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY_iphonesimulator = ENABLE_APPLE_PAY;
 ENABLE_APPLE_PAY[sdk=iphoneos9*] = ;
@@ -205,7 +205,7 @@
 ENABLE_FTL_JIT[sdk=macosx*] = ENABLE_FTL_JIT;
 ENABLE_FTL_JIT[sdk=iphoneos*] = ENABLE_FTL_JIT;
 
-ENABLE_VARIATION_FONTS[sdk=embedded*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
+ENABLE_VARIATION_FONTS[sdk=iphone*] = $(ENABLE_VARIATION_FONTS_$(PLATFORM_NAME));
 ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
 ENABLE_VARIATION_FONTS[sdk=iphoneos9*] = ;

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to