Title: [211526] trunk/Tools
- Revision
- 211526
- Author
- a...@apple.com
- Date
- 2017-02-01 14:02:04 -0800 (Wed, 01 Feb 2017)
Log Message
[Mac] TestWebKitAPI includes system frameworks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=167703
rdar://problem/30301498
Reviewed by Ryosuke Niwa.
FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
Also, reduced the number of subframework search paths, looks like we only need one now.
* TestWebKitAPI/Configurations/Base.xcconfig:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (211525 => 211526)
--- trunk/Tools/ChangeLog 2017-02-01 21:49:53 UTC (rev 211525)
+++ trunk/Tools/ChangeLog 2017-02-01 22:02:04 UTC (rev 211526)
@@ -1,3 +1,18 @@
+2017-02-01 Alexey Proskuryakov <a...@apple.com>
+
+ [Mac] TestWebKitAPI includes system frameworks incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=167703
+ rdar://problem/30301498
+
+ Reviewed by Ryosuke Niwa.
+
+ FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
+ Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
+
+ Also, reduced the number of subframework search paths, looks like we only need one now.
+
+ * TestWebKitAPI/Configurations/Base.xcconfig:
+
2017-02-01 Brent Fulgham <bfulg...@apple.com>
Correct "filesHaveSameVolume" predicate
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (211525 => 211526)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2017-02-01 21:49:53 UTC (rev 211525)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2017-02-01 22:02:04 UTC (rev 211526)
@@ -32,8 +32,6 @@
CLANG_CXX_LIBRARY = libc++;
CLANG_WARN_CXX0X_EXTENSIONS = NO;
HEADER_SEARCH_PATHS = ${BUILT_PRODUCTS_DIR}/usr/local/include $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(WEBCORE_PRIVATE_HEADERS_DIR)/icu $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport;
-FRAMEWORK_SEARCH_PATHS = $(FRAMEWORK_SEARCH_PATHS_$(PLATFORM_NAME));
-FRAMEWORK_SEARCH_PATHS_macosx = $(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(FEATURE_DEFINES) GTEST_HAS_TR1_TUPLE=0 GTEST_HAS_RTTI=0 $(GCC_PREPROCESSOR_DEFINITIONS_$(PLATFORM_NAME));
@@ -94,5 +92,6 @@
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *Mac.h *Mac.cpp *Mac.mm */mac/*;
OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
+OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
