Title: [211592] trunk/Source/WebCore
Revision
211592
Author
commit-qu...@webkit.org
Date
2017-02-02 13:31:20 -0800 (Thu, 02 Feb 2017)

Log Message

Unreviewed, rolling out r211579.
https://bugs.webkit.org/show_bug.cgi?id=167753

Caused mediastream crashes. (Requested by bfulgham_ on
#webkit).

Reverted changeset:

"Correct memory leak in MediaConstraints"
https://bugs.webkit.org/show_bug.cgi?id=167744
http://trac.webkit.org/changeset/211579

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (211591 => 211592)


--- trunk/Source/WebCore/ChangeLog	2017-02-02 21:29:15 UTC (rev 211591)
+++ trunk/Source/WebCore/ChangeLog	2017-02-02 21:31:20 UTC (rev 211592)
@@ -1,3 +1,17 @@
+2017-02-02  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r211579.
+        https://bugs.webkit.org/show_bug.cgi?id=167753
+
+        Caused mediastream crashes. (Requested by bfulgham_ on
+        #webkit).
+
+        Reverted changeset:
+
+        "Correct memory leak in MediaConstraints"
+        https://bugs.webkit.org/show_bug.cgi?id=167744
+        http://trac.webkit.org/changeset/211579
+
 2017-02-02  Chris Dumez  <cdu...@apple.com>
 
         Rename Node::inDocument() to isConnected()

Modified: trunk/Source/WebCore/platform/mediastream/MediaConstraints.h (211591 => 211592)


--- trunk/Source/WebCore/platform/mediastream/MediaConstraints.h	2017-02-02 21:29:15 UTC (rev 211591)
+++ trunk/Source/WebCore/platform/mediastream/MediaConstraints.h	2017-02-02 21:31:20 UTC (rev 211592)
@@ -713,7 +713,7 @@
 private:
     class ConstraintHolder {
     public:
-        static ConstraintHolder create(const MediaConstraint& value) { return ConstraintHolder(value); }
+        static ConstraintHolder& create(const MediaConstraint& value) { return *new ConstraintHolder(value); }
 
         ~ConstraintHolder()
         {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to