Title: [213219] trunk/Source/WebCore
Revision
213219
Author
tpop...@redhat.com
Date
2017-03-01 06:18:02 -0800 (Wed, 01 Mar 2017)

Log Message

[Cairo] Incorrectly determining height in GraphicsContext::roundToDevicePixels()
https://bugs.webkit.org/show_bug.cgi?id=169031

Reviewed by Carlos Garcia Campos.

We should compare if height is between -1 and 0 and not mixing height
and width together.

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (213218 => 213219)


--- trunk/Source/WebCore/ChangeLog	2017-03-01 14:16:37 UTC (rev 213218)
+++ trunk/Source/WebCore/ChangeLog	2017-03-01 14:18:02 UTC (rev 213219)
@@ -1,5 +1,18 @@
 2017-03-01  Tomas Popela  <tpop...@redhat.com>
 
+        [Cairo] Incorrectly determining height in GraphicsContext::roundToDevicePixels()
+        https://bugs.webkit.org/show_bug.cgi?id=169031
+
+        Reviewed by Carlos Garcia Campos.
+
+        We should compare if height is between -1 and 0 and not mixing height
+        and width together.
+
+        * platform/graphics/cairo/GraphicsContextCairo.cpp:
+        (WebCore::GraphicsContext::roundToDevicePixels):
+
+2017-03-01  Tomas Popela  <tpop...@redhat.com>
+
         [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events
         https://bugs.webkit.org/show_bug.cgi?id=169028
 

Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (213218 => 213219)


--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2017-03-01 14:16:37 UTC (rev 213218)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2017-03-01 14:18:02 UTC (rev 213219)
@@ -727,7 +727,7 @@
         width = 1;
     else
         width = round(width);
-    if (height > -1 && width < 0)
+    if (height > -1 && height < 0)
         height = -1;
     else if (height > 0 && height < 1)
         height = 1;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to