Title: [214101] trunk/Source/WebKit2
- Revision
- 214101
- Author
- tpop...@redhat.com
- Date
- 2017-03-17 02:45:55 -0700 (Fri, 17 Mar 2017)
Log Message
Fix uninitialized public members in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=169598
Reviewed by Alex Christensen.
Found by Coverity scan.
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cache/NetworkCacheStorage.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (214100 => 214101)
--- trunk/Source/WebKit2/ChangeLog 2017-03-17 08:22:57 UTC (rev 214100)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-17 09:45:55 UTC (rev 214101)
@@ -1,3 +1,15 @@
+2017-03-17 Tomas Popela <tpop...@redhat.com>
+
+ Fix uninitialized public members in NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=169598
+
+ Reviewed by Alex Christensen.
+
+ Found by Coverity scan.
+
+ * NetworkProcess/NetworkProcessCreationParameters.h:
+ * NetworkProcess/cache/NetworkCacheStorage.cpp:
+
2017-03-16 Alex Christensen <achristen...@webkit.org>
Fix GTK build.
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h (214100 => 214101)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-17 08:22:57 UTC (rev 214100)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-17 09:45:55 UTC (rev 214101)
@@ -49,18 +49,18 @@
void encode(IPC::Encoder&) const;
static bool decode(IPC::Decoder&, NetworkProcessCreationParameters&);
- bool privateBrowsingEnabled;
- CacheModel cacheModel;
+ bool privateBrowsingEnabled { false };
+ CacheModel cacheModel { CacheModelDocumentViewer };
int64_t diskCacheSizeOverride { -1 };
- bool canHandleHTTPSServerTrustEvaluation;
+ bool canHandleHTTPSServerTrustEvaluation { true };
String diskCacheDirectory;
SandboxExtension::Handle diskCacheDirectoryExtensionHandle;
#if ENABLE(NETWORK_CACHE)
- bool shouldEnableNetworkCache;
- bool shouldEnableNetworkCacheEfficacyLogging;
+ bool shouldEnableNetworkCache { false };
+ bool shouldEnableNetworkCacheEfficacyLogging { false };
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
- bool shouldEnableNetworkCacheSpeculativeRevalidation;
+ bool shouldEnableNetworkCacheSpeculativeRevalidation { false };
#endif
#endif
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
@@ -72,7 +72,7 @@
SandboxExtension::Handle parentBundleDirectoryExtensionHandle;
#endif
bool shouldSuppressMemoryPressureHandler { false };
- bool shouldUseTestingNetworkSession;
+ bool shouldUseTestingNetworkSession { false };
std::chrono::milliseconds loadThrottleLatency { 0ms };
Vector<String> urlSchemesRegisteredForCustomProtocols;
@@ -98,9 +98,9 @@
#if USE(SOUP)
String cookiePersistentStoragePath;
- uint32_t cookiePersistentStorageType;
- HTTPCookieAcceptPolicy cookieAcceptPolicy;
- bool ignoreTLSErrors;
+ uint32_t cookiePersistentStorageType { 0 };
+ HTTPCookieAcceptPolicy cookieAcceptPolicy { HTTPCookieAcceptPolicyAlways };
+ bool ignoreTLSErrors { false };
Vector<String> languages;
WebCore::SoupNetworkProxySettings proxySettings;
#endif
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (214100 => 214101)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-17 08:22:57 UTC (rev 214100)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-17 09:45:55 UTC (rev 214101)
@@ -367,13 +367,13 @@
Key key;
std::chrono::system_clock::time_point timeStamp;
SHA1::Digest headerHash;
- uint64_t headerSize;
+ uint64_t headerSize { 0 };
SHA1::Digest bodyHash;
- uint64_t bodySize;
- bool isBodyInline;
+ uint64_t bodySize { 0 };
+ bool isBodyInline { false };
// Not encoded as a field. Header starts immediately after meta data.
- uint64_t headerOffset;
+ uint64_t headerOffset { 0 };
};
static bool decodeRecordMetaData(RecordMetaData& metaData, const Data& fileData)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
