Title: [214198] trunk/Source/WebInspectorUI
- Revision
- 214198
- Author
- nvasil...@apple.com
- Date
- 2017-03-20 17:46:11 -0700 (Mon, 20 Mar 2017)
Log Message
REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely
https://bugs.webkit.org/show_bug.cgi?id=169899
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.resizerDragging):
leftMinimum and rightMaximum variables were always NaN because this.ColumnResizePadding is undefined.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214197 => 214198)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-21 00:19:53 UTC (rev 214197)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-21 00:46:11 UTC (rev 214198)
@@ -1,3 +1,14 @@
+2017-03-20 Nikita Vasilyev <nvasil...@apple.com>
+
+ REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely
+ https://bugs.webkit.org/show_bug.cgi?id=169899
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.resizerDragging):
+ leftMinimum and rightMaximum variables were always NaN because this.ColumnResizePadding is undefined.
+
2017-03-20 Matt Baker <mattba...@apple.com>
Web Inspector: Pseudo-class markers overlap DOM breakpoints and disclosure triangle
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (214197 => 214198)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-03-21 00:19:53 UTC (rev 214197)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-03-21 00:46:11 UTC (rev 214198)
@@ -1827,8 +1827,8 @@
let trailingEdgeOfNextColumn = leadingEdgeOfPreviousColumn + firstRowCells[leftColumnIndex].offsetWidth + firstRowCells[rightColumnIndex].offsetWidth;
// Give each column some padding so that they don't disappear.
- let leftMinimum = leadingEdgeOfPreviousColumn + this.ColumnResizePadding;
- let rightMaximum = trailingEdgeOfNextColumn - this.ColumnResizePadding;
+ let leftMinimum = leadingEdgeOfPreviousColumn + WebInspector.DataGrid.ColumnResizePadding;
+ let rightMaximum = trailingEdgeOfNextColumn - WebInspector.DataGrid.ColumnResizePadding;
dragPoint = Number.constrain(dragPoint, leftMinimum, rightMaximum);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
