Title: [214299] trunk/Source/WTF
Revision
214299
Author
tpop...@redhat.com
Date
2017-03-23 02:10:36 -0700 (Thu, 23 Mar 2017)

Log Message

Fix uninitialized public members in WTF
https://bugs.webkit.org/show_bug.cgi?id=169676

Reviewed by Michael Catanzaro.

Found by Coverity scan.

* wtf/Bag.h:
* wtf/HashTable.h:
* wtf/HashTraits.h:
* wtf/Insertion.h:
* wtf/OrderMaker.h:
* wtf/ParallelJobsGeneric.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (214298 => 214299)


--- trunk/Source/WTF/ChangeLog	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/ChangeLog	2017-03-23 09:10:36 UTC (rev 214299)
@@ -1,3 +1,19 @@
+2017-03-23  Tomas Popela  <tpop...@redhat.com>
+
+        Fix uninitialized public members in WTF
+        https://bugs.webkit.org/show_bug.cgi?id=169676
+
+        Reviewed by Michael Catanzaro.
+
+        Found by Coverity scan.
+
+        * wtf/Bag.h:
+        * wtf/HashTable.h:
+        * wtf/HashTraits.h:
+        * wtf/Insertion.h:
+        * wtf/OrderMaker.h:
+        * wtf/ParallelJobsGeneric.h:
+
 2017-03-22  Andreas Kling  <akl...@apple.com>
 
         Let MemoryPressureHandler track whether the process is active or inactive.

Modified: trunk/Source/WTF/wtf/Bag.h (214298 => 214299)


--- trunk/Source/WTF/wtf/Bag.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/Bag.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -43,7 +43,7 @@
         }
         
         T m_item;
-        Node* m_next;
+        Node* m_next { nullptr };
     };
     
 public:

Modified: trunk/Source/WTF/wtf/HashTable.h (214298 => 214299)


--- trunk/Source/WTF/wtf/HashTable.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/HashTable.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -225,8 +225,8 @@
         void checkValidity(const const_iterator&) const { }
 #endif
 
-        PointerType m_position;
-        PointerType m_endPosition;
+        PointerType m_position { nullptr };
+        PointerType m_endPosition { nullptr };
 
 #if CHECK_HASHTABLE_ITERATORS
     public:

Modified: trunk/Source/WTF/wtf/HashTraits.h (214298 => 214299)


--- trunk/Source/WTF/wtf/HashTraits.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/HashTraits.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -302,7 +302,7 @@
     }
 
     KeyTypeArg key;
-    ValueTypeArg value;
+    ValueTypeArg value { };
 };
 
 template<typename KeyTraitsArg, typename ValueTraitsArg>

Modified: trunk/Source/WTF/wtf/Insertion.h (214298 => 214299)


--- trunk/Source/WTF/wtf/Insertion.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/Insertion.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -50,8 +50,8 @@
     }
     
 private:
-    size_t m_index;
-    T m_element;
+    size_t m_index { 0 };
+    T m_element { };
 };
 
 template<typename TargetVectorType, typename InsertionVectorType>

Modified: trunk/Source/WTF/wtf/OrderMaker.h (214298 => 214299)


--- trunk/Source/WTF/wtf/OrderMaker.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/OrderMaker.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -50,7 +50,7 @@
         {
         }
 
-        T payload;
+        T payload { };
     };
     
 public:

Modified: trunk/Source/WTF/wtf/ParallelJobsGeneric.h (214298 => 214299)


--- trunk/Source/WTF/wtf/ParallelJobsGeneric.h	2017-03-23 07:38:53 UTC (rev 214298)
+++ trunk/Source/WTF/wtf/ParallelJobsGeneric.h	2017-03-23 09:10:36 UTC (rev 214299)
@@ -81,8 +81,8 @@
         mutable Lock m_mutex;
         Condition m_threadCondition;
 
-        ThreadFunction m_threadFunction;
-        void* m_parameters;
+        ThreadFunction m_threadFunction { nullptr };
+        void* m_parameters { nullptr };
     };
 
 private:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to