Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js (214495 => 214496)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js 2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js 2017-03-28 21:56:10 UTC (rev 214496)
@@ -106,4 +106,15 @@
"containsBranchLocation": true,
"branches": ["trunk"]
}
-];
\ No newline at end of file
+];
+
+MockTrac.recordedCommitIndicesByRevisionNumber = {
+ 33018: 0,
+ 33019: 1,
+ 33020: 2,
+ 33021: 3,
+ 33022: 4,
+ 33023: 5,
+ 33024: 6,
+ 33025: 7
+};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214495 => 214496)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 21:56:10 UTC (rev 214496)
@@ -91,6 +91,7 @@
test("nextRevision", function()
{
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
strictEqual(this.trac.nextRevision("trunk", "33020"), "33022", "nextRevision same branch");
strictEqual(this.trac.nextRevision("trunk", "33019"), "33020", "nextRevision different branch");
});
@@ -98,6 +99,7 @@
test("indexOfRevision", function()
{
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
strictEqual(this.trac.indexOfRevision("33020"), 2, "indexOfRevision");
});
@@ -104,6 +106,7 @@
test("commitsOnBranchLaterThanRevision", function()
{
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
var commits = this.trac.commitsOnBranchLaterThanRevision("trunk", "33020");
equal(commits.length, 1, "greater than 33020");
});
@@ -111,6 +114,7 @@
test("commitsOnBranchLaterThanRevision no commits", function()
{
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
var commits = this.trac.commitsOnBranchLaterThanRevision("someOtherBranch", "33021");
equal(commits.length, 0, "greater than 33021");
});
@@ -118,6 +122,7 @@
test("commitsOnBranchInRevisionRange", function()
{
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
var commits = this.trac.commitsOnBranchInRevisionRange("trunk", "33020", "33022");
equal(commits.length, 2, "in range 33020, 33022");
});
@@ -156,6 +161,7 @@
setup: function() {
this.trac = new MockTrac();
this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
this.queue = new MockBuildbotQueue();
this.trunkBranch = {
name: "trunk",
@@ -382,6 +388,7 @@
setup: function() {
Dashboard.Repository.OpenSource.trac = new MockTrac();
Dashboard.Repository.OpenSource.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+ Dashboard.Repository.OpenSource.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
this.queue = new MockBuildbotQueue();
this.queue.branches = [{
name: "trunk",
Modified: trunk/Tools/ChangeLog (214495 => 214496)
--- trunk/Tools/ChangeLog 2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/ChangeLog 2017-03-28 21:56:10 UTC (rev 214496)
@@ -1,3 +1,15 @@
+2017-03-28 Aakash Jain <aakash_j...@apple.com>
+
+ Dashboard tests fails to fetch the revision from commits
+ https://bugs.webkit.org/show_bug.cgi?id=170191
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
+ Added recordedCommitIndicesByRevisionNumber.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+ (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
+
2017-03-28 Timothy Horton <timothy_hor...@apple.com>
Safari crashes when attempting to close tab that is displaying PDF
