Title: [215178] trunk
- Revision
- 215178
- Author
- carlo...@webkit.org
- Date
- 2017-04-10 04:44:21 -0700 (Mon, 10 Apr 2017)
Log Message
REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
https://bugs.webkit.org/show_bug.cgi?id=170667
Reviewed by Žan Doberšek.
Tools:
In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
that value.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
LayoutTests:
Unskip then test that is passing now.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (215177 => 215178)
--- trunk/LayoutTests/ChangeLog 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/LayoutTests/ChangeLog 2017-04-10 11:44:21 UTC (rev 215178)
@@ -1,5 +1,16 @@
2017-04-10 Carlos Garcia Campos <cgar...@igalia.com>
+ REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
+ https://bugs.webkit.org/show_bug.cgi?id=170667
+
+ Reviewed by Žan Doberšek.
+
+ Unskip then test that is passing now.
+
+ * platform/gtk/TestExpectations:
+
+2017-04-10 Carlos Garcia Campos <cgar...@igalia.com>
+
Unreviewed GTK+ gardening. Mark several tests as failing/timing out.
* platform/gtk/TestExpectations:
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (215177 => 215178)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 11:44:21 UTC (rev 215178)
@@ -3495,8 +3495,6 @@
webkit.org/b/170335 canvas/philip/tests/2d.pattern.animated.gif.html [ Failure ]
webkit.org/b/170335 svg/animations/animated-svg-image-outside-viewport-paused.html [ Failure ]
-webkit.org/b/170667 media/video-click-dblckick-standalone.html [ Failure ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of non-crashing, non-flaky tests failing
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Tools/ChangeLog (215177 => 215178)
--- trunk/Tools/ChangeLog 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/Tools/ChangeLog 2017-04-10 11:44:21 UTC (rev 215178)
@@ -1,5 +1,18 @@
2017-04-10 Carlos Garcia Campos <cgar...@igalia.com>
+ REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
+ https://bugs.webkit.org/show_bug.cgi?id=170667
+
+ Reviewed by Žan Doberšek.
+
+ In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
+ that value.
+
+ * WebKitTestRunner/gtk/TestControllerGtk.cpp:
+ (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
+
+2017-04-10 Carlos Garcia Campos <cgar...@igalia.com>
+
WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=170653
Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (215177 => 215178)
--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2017-04-10 11:44:21 UTC (rev 215178)
@@ -155,8 +155,9 @@
m_mainWebView->dismissAllPopupMenus();
}
-void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions&, const std::string&) const
+void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions& options, const std::string&) const
{
+ options.enableModernMediaControls = false;
}
} // namespace WTR
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
