Diff
Modified: trunk/Source/WebCore/ChangeLog (215197 => 215198)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 19:59:26 UTC (rev 215198)
@@ -1,3 +1,22 @@
+2017-04-10 Youenn Fablet <you...@apple.com>
+
+ Remove deprecated parts of media stream spec
+ https://bugs.webkit.org/show_bug.cgi?id=169879
+
+ Reviewed by Jon Lee.
+
+ Removing MediaStreamTrackState 'new' value which was unused.
+ Removing MediaStreamTrack _readonly attribute which was unused.
+
+ * Modules/mediastream/MediaStreamTrack.cpp:
+ (WebCore::MediaStreamTrack::readonly): Deleted.
+ * Modules/mediastream/MediaStreamTrack.h:
+ * Modules/mediastream/MediaStreamTrack.idl:
+ * platform/mediastream/MediaStreamTrackPrivate.cpp:
+ (WebCore::MediaStreamTrackPrivate::readonly): Deleted.
+ * platform/mediastream/MediaStreamTrackPrivate.h:
+ * platform/mediastream/RealtimeMediaSource.h:
+
2017-04-10 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r215175.
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:59:26 UTC (rev 215198)
@@ -98,11 +98,6 @@
return m_private->muted();
}
-bool MediaStreamTrack::readonly() const
-{
- return m_private->readonly();
-}
-
auto MediaStreamTrack::readyState() const -> State
{
return ended() ? State::Ended : State::Live;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:59:26 UTC (rev 215198)
@@ -64,9 +64,8 @@
void setEnabled(bool);
bool muted() const;
- bool readonly() const;
- enum class State { New, Live, Ended };
+ enum class State { Live, Ended };
State readyState() const;
bool ended() const;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:59:26 UTC (rev 215198)
@@ -24,7 +24,7 @@
*/
// FIXME 169871: remove "new"
-enum MediaStreamTrackState { "new", "live", "ended" };
+enum MediaStreamTrackState { "live", "ended" };
[
ActiveDOMObject,
@@ -53,9 +53,6 @@
Promise<void> applyConstraints(optional MediaTrackConstraints constraints);
attribute EventHandler onoverconstrained;
-
- // FIXME 169871: legacy or remove?
- readonly attribute boolean _readonly;
};
[
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:59:26 UTC (rev 215198)
@@ -80,11 +80,6 @@
return m_source->muted();
}
-bool MediaStreamTrackPrivate::readonly() const
-{
- return m_source->readonly();
-}
-
bool MediaStreamTrackPrivate::isCaptureTrack() const
{
return m_source->isCaptureSource();
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2017-04-10 19:59:26 UTC (rev 215198)
@@ -71,7 +71,6 @@
bool muted() const;
void setMuted(bool muted) { m_source->setMuted(muted); }
- bool readonly() const;
bool isCaptureTrack() const;
bool enabled() const { return m_isEnabled; }
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2017-04-10 19:59:26 UTC (rev 215198)
@@ -63,7 +63,6 @@
{
m_stopped = false;
m_muted = false;
- m_readonly = false;
}
void RealtimeMediaSource::addObserver(RealtimeMediaSource::Observer& observer)
@@ -147,11 +146,6 @@
observer->audioSamplesAvailable(time, audioData, description, numberOfFrames);
}
-bool RealtimeMediaSource::readonly() const
-{
- return m_readonly;
-}
-
void RealtimeMediaSource::stop(Observer* callingObserver)
{
if (stopped())
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2017-04-10 19:59:26 UTC (rev 215198)
@@ -133,9 +133,6 @@
virtual bool enabled() const { return m_enabled; }
virtual void setEnabled(bool);
- virtual bool readonly() const;
- virtual void setReadonly(bool readonly) { m_readonly = readonly; }
-
virtual bool isCaptureSource() const { return false; }
WEBCORE_EXPORT void addObserver(Observer&);
@@ -228,7 +225,6 @@
bool m_echoCancellation { false };
bool m_stopped { false };
- bool m_readonly { false };
bool m_pendingSettingsDidChangeNotification { false };
bool m_suppressNotifications { true };
};
