Title: [215332] trunk/LayoutTests
- Revision
- 215332
- Author
- cdu...@apple.com
- Date
- 2017-04-13 12:42:35 -0700 (Thu, 13 Apr 2017)
Log Message
LayoutTest svg/animations/animated-svg-image-outside-viewport-paused.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170745
Reviewed by Tim Horton.
Test was relying on a setTimeout(30) and was flaky. Now use shouldBecomeEqual() to make the
test more robust.
* svg/animations/animated-svg-image-outside-viewport-paused-expected.txt:
* svg/animations/animated-svg-image-outside-viewport-paused.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (215331 => 215332)
--- trunk/LayoutTests/ChangeLog 2017-04-13 19:34:21 UTC (rev 215331)
+++ trunk/LayoutTests/ChangeLog 2017-04-13 19:42:35 UTC (rev 215332)
@@ -1,3 +1,16 @@
+2017-04-13 Chris Dumez <cdu...@apple.com>
+
+ LayoutTest svg/animations/animated-svg-image-outside-viewport-paused.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=170745
+
+ Reviewed by Tim Horton.
+
+ Test was relying on a setTimeout(30) and was flaky. Now use shouldBecomeEqual() to make the
+ test more robust.
+
+ * svg/animations/animated-svg-image-outside-viewport-paused-expected.txt:
+ * svg/animations/animated-svg-image-outside-viewport-paused.html:
+
2017-04-13 Youenn Fablet <you...@apple.com>
Remove RTCSignalingState::Closed
Modified: trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused-expected.txt (215331 => 215332)
--- trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused-expected.txt 2017-04-13 19:34:21 UTC (rev 215331)
+++ trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused-expected.txt 2017-04-13 19:42:35 UTC (rev 215332)
@@ -4,7 +4,7 @@
Initially outside the viewport
-PASS internals.isImageAnimating(image) is false
+PASS internals.isImageAnimating(image) became false
Scrolling animation into view
PASS internals.isImageAnimating(image) became true
Scrolling animation outside view again
Modified: trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused.html (215331 => 215332)
--- trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused.html 2017-04-13 19:34:21 UTC (rev 215331)
+++ trunk/LayoutTests/svg/animations/animated-svg-image-outside-viewport-paused.html 2017-04-13 19:42:35 UTC (rev 215332)
@@ -9,10 +9,8 @@
_onload_ = function() {
image = document.querySelector("img");
- setTimeout(function() {
- debug("Initially outside the viewport");
- shouldBeFalse("internals.isImageAnimating(image)");
-
+ debug("Initially outside the viewport");
+ shouldBecomeEqual("internals.isImageAnimating(image)", "false", function() {
debug("Scrolling animation into view");
internals.scrollElementToRect(image, 0, 0, 300, 300);
shouldBecomeEqual("internals.isImageAnimating(image)", "true", function() {
@@ -20,7 +18,7 @@
scroll(0, 0);
shouldBecomeEqual("internals.isImageAnimating(image)", "false", finishJSTest);
});
- }, 30);
+ });
}
</script>
<div style="position: relative; width: 1600px; height: 2400px;">
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
