Title: [215333] trunk/Source/WebInspectorUI
Revision
215333
Author
bb...@apple.com
Date
2017-04-13 12:54:53 -0700 (Thu, 13 Apr 2017)

Log Message

Web Inspector: RTL: goto arrow is floated to the wrong side
https://bugs.webkit.org/show_bug.cgi?id=170816

Reviewed by Matt Baker.

Float it to the other side if necessary.

* UserInterface/Views/Main.css:
(.go-to-link):
(body[dir=ltr] .go-to-link:not(.dont-float)):
(body[dir=rtl] .go-to-link:not(.dont-float)):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (215332 => 215333)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-04-13 19:42:35 UTC (rev 215332)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-04-13 19:54:53 UTC (rev 215333)
@@ -1,3 +1,17 @@
+2017-04-13  Brian Burg  <bb...@apple.com>
+
+        Web Inspector: RTL: goto arrow is floated to the wrong side
+        https://bugs.webkit.org/show_bug.cgi?id=170816
+
+        Reviewed by Matt Baker.
+
+        Float it to the other side if necessary.
+
+        * UserInterface/Views/Main.css:
+        (.go-to-link):
+        (body[dir=ltr] .go-to-link:not(.dont-float)):
+        (body[dir=rtl] .go-to-link:not(.dont-float)):
+
 2017-04-12  Dan Bernstein  <m...@apple.com>
 
         [Mac] Future-proof .xcconfig files

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (215332 => 215333)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css	2017-04-13 19:42:35 UTC (rev 215332)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css	2017-04-13 19:54:53 UTC (rev 215333)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -270,14 +270,24 @@
 }
 
 .go-to-link:not(.dont-float) {
-    float: right;
-    margin-left: 5px;
     max-width: 100%;
     text-overflow: ellipsis;
     overflow: hidden;
     white-space: nowrap;
+
+    --go-to-link-margin-start: 5px;
 }
 
+body[dir=ltr] .go-to-link:not(.dont-float) {
+    float: right;
+    margin-left: var(--go-to-link-margin-start);
+}
+
+body[dir=rtl] .go-to-link:not(.dont-float) {
+    float: left;
+    margin-right: var(--go-to-link-margin-start);
+}
+
 .go-to-arrow {
     -webkit-appearance: none;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to