Title: [215688] trunk
Revision
215688
Author
commit-qu...@webkit.org
Date
2017-04-24 11:08:56 -0700 (Mon, 24 Apr 2017)

Log Message

Address some FIXMEs in _javascript_ tests for bugs that have been fixed
https://bugs.webkit.org/show_bug.cgi?id=171191

Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-04-24
Reviewed by JF Bastien.

JSTests:

* stress/proxy-is-extensible.js:

LayoutTests:

* js/dom/custom-constructors-expected.txt:
* js/dom/script-tests/custom-constructors.js:
* js/script-tests/keyword-method-names.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (215687 => 215688)


--- trunk/JSTests/ChangeLog	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/JSTests/ChangeLog	2017-04-24 18:08:56 UTC (rev 215688)
@@ -1,5 +1,14 @@
 2017-04-24  Joseph Pecoraro  <pecor...@apple.com>
 
+        Address some FIXMEs in _javascript_ tests for bugs that have been fixed
+        https://bugs.webkit.org/show_bug.cgi?id=171191
+
+        Reviewed by JF Bastien.
+
+        * stress/proxy-is-extensible.js:
+
+2017-04-24  Joseph Pecoraro  <pecor...@apple.com>
+
         test262: test262/test/language/statements/for-of/dstr-array-elem-init-fn-name-arrow.js
         https://bugs.webkit.org/show_bug.cgi?id=171160
 

Modified: trunk/JSTests/stress/proxy-is-extensible.js (215687 => 215688)


--- trunk/JSTests/stress/proxy-is-extensible.js	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/JSTests/stress/proxy-is-extensible.js	2017-04-24 18:08:56 UTC (rev 215688)
@@ -301,9 +301,6 @@
     }
 }
 
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=154650
-// needs to land for this test to pass because it depends on Proxy.[[OwnPropertyKeys]].
-/*
 {
     let target = {};
     Object.defineProperty(target, "x", {
@@ -341,5 +338,3 @@
         called = false;
     }
 }
-*/
-

Modified: trunk/LayoutTests/ChangeLog (215687 => 215688)


--- trunk/LayoutTests/ChangeLog	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/LayoutTests/ChangeLog	2017-04-24 18:08:56 UTC (rev 215688)
@@ -1,5 +1,16 @@
 2017-04-24  Joseph Pecoraro  <pecor...@apple.com>
 
+        Address some FIXMEs in _javascript_ tests for bugs that have been fixed
+        https://bugs.webkit.org/show_bug.cgi?id=171191
+
+        Reviewed by JF Bastien.
+
+        * js/dom/custom-constructors-expected.txt:
+        * js/dom/script-tests/custom-constructors.js:
+        * js/script-tests/keyword-method-names.js:
+
+2017-04-24  Joseph Pecoraro  <pecor...@apple.com>
+
         test262: test262/test/language/expressions/generators/yield-as-label.js
         https://bugs.webkit.org/show_bug.cgi?id=170979
 

Modified: trunk/LayoutTests/js/dom/custom-constructors-expected.txt (215687 => 215688)


--- trunk/LayoutTests/js/dom/custom-constructors-expected.txt	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/LayoutTests/js/dom/custom-constructors-expected.txt	2017-04-24 18:08:56 UTC (rev 215688)
@@ -12,7 +12,7 @@
 PASS new Image(-100).width is 0
 PASS new Image(-100, -200).height is 0
 PASS new Image().outerHTML is "<img>"
-PASS new Image(100, 100).outerHTML.replace(/"/g, "'") is "<img width='100' height='100'>"
+PASS new Image(100, 100).outerHTML is "<img width=\"100\" height=\"100\">"
 PASS new Option() is non-null.
 PASS new Option().tagName is "OPTION"
 PASS new Option().innerText is ""

Modified: trunk/LayoutTests/js/dom/script-tests/custom-constructors.js (215687 => 215688)


--- trunk/LayoutTests/js/dom/script-tests/custom-constructors.js	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/LayoutTests/js/dom/script-tests/custom-constructors.js	2017-04-24 18:08:56 UTC (rev 215688)
@@ -14,8 +14,7 @@
 shouldBe("new Image(-100, -200).height", "0");
 
 shouldBeEqualToString("new Image().outerHTML","<img>");
-// FIXME: shouldBeEqualToString strips quotes from the string.
-shouldBeEqualToString("new Image(100, 100).outerHTML.replace(/\"/g, \"'\")", "<img width='100' height='100'>");
+shouldBeEqualToString("new Image(100, 100).outerHTML", '<img width="100" height="100">');
 
 // Option tests
 shouldBeNonNull("new Option()");

Modified: trunk/LayoutTests/js/script-tests/keyword-method-names.js (215687 => 215688)


--- trunk/LayoutTests/js/script-tests/keyword-method-names.js	2017-04-24 17:59:49 UTC (rev 215687)
+++ trunk/LayoutTests/js/script-tests/keyword-method-names.js	2017-04-24 18:08:56 UTC (rev 215688)
@@ -6,6 +6,8 @@
     constructor() { } // NOTE: This has semantic meaning here, but is allowed.
     abstract() { }
     arguments() { }
+    async() { }
+    await() { }
     boolean() { }
     break() { }
     byte() { }
@@ -75,8 +77,7 @@
 class ClassWithKeywordStaticMethodNames {
     static constructor() { }
     static abstract() { }
-    // FIXME: <https://webkit.org/b/152985> ES6: Classes: Should be allowed to create a static method with name "arguments"
-    // static arguments() { }
+    static arguments() { }
     static boolean() { }
     static break() { }
     static byte() { }
@@ -141,6 +142,8 @@
     static while() { }
     static with() { }
     static yield() { }
+    static async() { }
+    static await() { }
 };
 
 class ClassWithKeywordGetterMethodNames {
@@ -147,6 +150,8 @@
     // get constructor() { } (getter `constructor` not allowed)
     get abstract() { }
     get arguments() { }
+    get async() { }
+    get await() { }
     get boolean() { }
     get break() { }
     get byte() { }
@@ -217,6 +222,8 @@
     // set constructor() { } (setter `constructor` not allowed)
     set abstract(x) { }
     set arguments(x) { }
+    set async(x) { }
+    set await(x) { }
     set boolean(x) { }
     set break(x) { }
     set byte(x) { }
@@ -287,6 +294,8 @@
     constructor() { },
     abstract() { },
     arguments() { },
+    async() { },
+    await() { },
     boolean() { },
     break() { },
     byte() { },
@@ -357,6 +366,8 @@
     get constructor() { },
     get abstract() { },
     get arguments() { },
+    get async() { },
+    get await() { },
     get boolean() { },
     get break() { },
     get byte() { },
@@ -427,6 +438,8 @@
     set constructor(x) { },
     set abstract(x) { },
     set arguments(x) { },
+    set async(x) { },
+    set await(x) { },
     set boolean(x) { },
     set break(x) { },
     set byte(x) { },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to