Diff
Modified: trunk/Tools/ChangeLog (215981 => 215982)
--- trunk/Tools/ChangeLog 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/ChangeLog 2017-04-30 05:02:20 UTC (rev 215982)
@@ -1,3 +1,22 @@
+2017-04-29 Aakash Jain <aakash_j...@apple.com>
+
+ Use PEP8 style guide for raising exceptions in webkitpy.
+ https://bugs.webkit.org/show_bug.cgi?id=171439
+
+ Reviewed by Daniel Bates.
+
+ As per https://www.python.org/dev/peps/pep-0008/
+ "When raising an exception in Python 2, use raise ValueError('message')
+ instead of the older form raise ValueError, 'message'"
+
+ * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
+ * Scripts/webkitpy/common/thread/messagepump.py: Same.
+ * Scripts/webkitpy/tool/bot/queueengine.py: Same.
+ * Scripts/webkitpy/tool/commands/queues.py: Same.
+ * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
+ * Scripts/webkitpy/tool/multicommandtool.py: Same.
+ * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
+
2017-04-28 Simon Fraser <simon.fra...@apple.com>
Add system trace points for Document::updateTouchEventRegions()
Modified: trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -35,13 +35,13 @@
class IRCBotDelegate(object):
def irc_message_received(self, nick, message):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def irc_nickname(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def irc_password(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
class IRCBot(ircbot.SingleServerIRCBot, MessagePumpDelegate):
Modified: trunk/Tools/Scripts/webkitpy/common/thread/messagepump.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/common/thread/messagepump.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/common/thread/messagepump.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -29,13 +29,13 @@
class MessagePumpDelegate(object):
def schedule(self, interval, callback):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def message_available(self, message):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def final_message_delivered(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
class MessagePump(object):
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -49,25 +49,25 @@
class QueueEngineDelegate:
def queue_log_path(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def work_item_log_path(self, work_item):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def begin_work_queue(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def should_continue_work_queue(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def next_work_item(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def process_work_item(self, work_item):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def handle_unexpected_error(self, work_item, message):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
class QueueEngine:
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -118,7 +118,7 @@
return os.path.join(self._log_directory(), "%s.log" % self.name)
def work_item_log_path(self, work_item):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def begin_work_queue(self):
_log.info("CAUTION: %s will discard all local changes in \"%s\"" % (self.name, self._tool.scm().checkout_root))
@@ -138,13 +138,13 @@
return not self._options.iterations or self._iteration_count <= self._options.iterations
def next_work_item(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def process_work_item(self, work_item):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def handle_unexpected_error(self, work_item, message):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
# Command methods
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -40,11 +40,11 @@
class StepSequenceErrorHandler():
@classmethod
def handle_script_error(cls, tool, patch, script_error):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
@classmethod
def handle_checkout_needs_update(cls, tool, state, options, error):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
class StepSequence(object):
Modified: trunk/Tools/Scripts/webkitpy/tool/multicommandtool.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/tool/multicommandtool.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/tool/multicommandtool.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -130,7 +130,7 @@
return help_text
def execute(self, options, args, tool):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
# main() exists so that Commands can be turned into stand-alone scripts.
# Other parts of the code will likely require modification to work stand-alone.
@@ -262,7 +262,7 @@
return None
def path(self):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
def command_completed(self):
pass
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/abstractstep.py (215981 => 215982)
--- trunk/Tools/Scripts/webkitpy/tool/steps/abstractstep.py 2017-04-30 03:32:58 UTC (rev 215981)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/abstractstep.py 2017-04-30 05:02:20 UTC (rev 215982)
@@ -76,4 +76,4 @@
]
def run(self, state):
- raise NotImplementedError, "subclasses must implement"
+ raise NotImplementedError('subclasses must implement')
