Title: [216404] releases/WebKitGTK/webkit-2.16
Revision
216404
Author
carlo...@webkit.org
Date
2017-05-08 06:32:39 -0700 (Mon, 08 May 2017)

Log Message

Merge r216139 - YouTube user agent quirk breaks new YouTube
https://bugs.webkit.org/show_bug.cgi?id=171603

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the YouTube quirk test.

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216403 => 216404)


--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:32:39 UTC (rev 216404)
@@ -1,3 +1,19 @@
+2017-05-03  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        YouTube user agent quirk breaks new YouTube
+        https://bugs.webkit.org/show_bug.cgi?id=171603
+
+        Reviewed by Carlos Garcia Campos.
+
+        Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
+        attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
+        have to remove this quirk.
+
+        Note this does not affect Safari as Apple ports don't use our user agent quirks.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresChromeBrowser):
+
 2017-05-03  Zalan Bujtas  <za...@apple.com>
 
         RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp (216403 => 216404)


--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:32:39 UTC (rev 216404)
@@ -66,10 +66,6 @@
     if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
         return true;
 
-    // Needed for YouTube 360 with WebKitGTK+ and WPE (requires ENABLE_MEDIA_SOURCE).
-    if (baseDomain == "youtube.com")
-        return true;
-
     // Slack completely blocks users with WebKitGTK+'s standard user agent.
     if (baseDomain == "slack.com")
         return true;

Modified: releases/WebKitGTK/webkit-2.16/Tools/ChangeLog (216403 => 216404)


--- releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:32:39 UTC (rev 216404)
@@ -1,3 +1,15 @@
+2017-05-03  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        YouTube user agent quirk breaks new YouTube
+        https://bugs.webkit.org/show_bug.cgi?id=171603
+
+        Reviewed by Carlos Garcia Campos.
+
+        Remove the YouTube quirk test.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2017-04-25  Alex Christensen  <achristen...@webkit.org>
 
         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set

Modified: releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (216403 => 216404)


--- releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:32:39 UTC (rev 216404)
@@ -89,7 +89,6 @@
 
     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
-    assertUserAgentForURLHasChromeBrowserQuirk("http://www.youtube.com/");
     assertUserAgentForURLHasChromeBrowserQuirk("http://www.slack.com/");
 
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://www.google.com/");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to