Title: [216430] trunk/Source/_javascript_Core
Revision
216430
Author
jfbast...@apple.com
Date
2017-05-08 10:06:29 -0700 (Mon, 08 May 2017)

Log Message

WebAssembly: don't just emit extended offset adds for patch
https://bugs.webkit.org/show_bug.cgi?id=171799

Reviewed by Mark Lam.

It isn't necessary to restrict.

* b3/air/AirLowerStackArgs.cpp:
(JSC::B3::Air::lowerStackArgs):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216429 => 216430)


--- trunk/Source/_javascript_Core/ChangeLog	2017-05-08 16:58:13 UTC (rev 216429)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-08 17:06:29 UTC (rev 216430)
@@ -1,3 +1,15 @@
+2017-05-08  JF Bastien  <jfbast...@apple.com>
+
+        WebAssembly: don't just emit extended offset adds for patch
+        https://bugs.webkit.org/show_bug.cgi?id=171799
+
+        Reviewed by Mark Lam.
+
+        It isn't necessary to restrict.
+
+        * b3/air/AirLowerStackArgs.cpp:
+        (JSC::B3::Air::lowerStackArgs):
+
 2017-05-08  Mark Lam  <mark....@apple.com>
 
         Introduce ExceptionScope::assertNoException() and releaseAssertNoException().

Modified: trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp (216429 => 216430)


--- trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp	2017-05-08 16:58:13 UTC (rev 216429)
+++ trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp	2017-05-08 17:06:29 UTC (rev 216430)
@@ -70,7 +70,6 @@
 
         for (unsigned instIndex = 0; instIndex < block->size(); ++instIndex) {
             Inst& inst = block->at(instIndex);
-            bool isPatch = inst.kind.opcode == Patch;
 
             inst.forEachArg(
                 [&] (Arg& arg, Arg::Role role, Bank, Width width) {
@@ -77,7 +76,7 @@
                     auto stackAddr = [&] (Value::OffsetType offsetFromFP) -> Arg {
                         int32_t offsetFromSP = offsetFromFP + code.frameSize();
 
-                        if (isPatch && inst.admitsExtendedOffsetAddr(arg)) {
+                        if (inst.admitsExtendedOffsetAddr(arg)) {
                             // Stackmaps and patchpoints expect addr inputs relative to SP or FP only. We might as well
                             // not even bother generating an addr with valid form for these opcodes since extended offset
                             // addr is always valid.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to