Title: [216969] trunk/LayoutTests
- Revision
- 216969
- Author
- cdu...@apple.com
- Date
- 2017-05-16 22:26:10 -0700 (Tue, 16 May 2017)
Log Message
[macOS Debug wk2] Layout test svg/animations/animations-paused-in-background-page-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=172183
Reviewed by Andreas Kling.
Fix test flakiness by using shouldBecome() instead of relying on a 30ms timer.
* svg/animations/animations-paused-in-background-page-iframe-expected.txt:
* svg/animations/animations-paused-in-background-page-iframe.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (216968 => 216969)
--- trunk/LayoutTests/ChangeLog 2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/ChangeLog 2017-05-17 05:26:10 UTC (rev 216969)
@@ -1,3 +1,15 @@
+2017-05-16 Chris Dumez <cdu...@apple.com>
+
+ [macOS Debug wk2] Layout test svg/animations/animations-paused-in-background-page-iframe.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=172183
+
+ Reviewed by Andreas Kling.
+
+ Fix test flakiness by using shouldBecome() instead of relying on a 30ms timer.
+
+ * svg/animations/animations-paused-in-background-page-iframe-expected.txt:
+ * svg/animations/animations-paused-in-background-page-iframe.html:
+
2017-05-16 Sam Weinig <s...@webkit.org>
Bring Notification.idl up to spec
Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt (216968 => 216969)
--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt 2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt 2017-05-17 05:26:10 UTC (rev 216969)
@@ -5,7 +5,7 @@
Setting page visibility to hidden
PASS document.hidden is true
-PASS internals.isImageAnimating(testImage) is false
+PASS internals.isImageAnimating(testImage) became false
Setting page visibility to visible
PASS internals.isImageAnimating(testImage) became true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html (216968 => 216969)
--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html 2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html 2017-05-17 05:26:10 UTC (rev 216969)
@@ -8,10 +8,8 @@
function frameLoadedInBackground()
{
- setTimeout(function() {
- testImage = frame.contentDocument.getElementById("testImage");
- shouldBeFalse("internals.isImageAnimating(testImage)");
-
+ testImage = frame.contentDocument.getElementById("testImage");
+ shouldBecomeEqual("internals.isImageAnimating(testImage)", "false", function() {
document._onvisibilitychange_ = null;
debug("Setting page visibility to visible");
if (window.testRunner)
@@ -18,7 +16,7 @@
testRunner.setPageVisibility('visible');
shouldBecomeEqual("internals.isImageAnimating(testImage)", "true", finishJSTest);
- }, 30);
+ });
}
window._onload_ = function() {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
