Title: [218320] trunk/Tools
Revision
218320
Author
commit-qu...@webkit.org
Date
2017-06-15 00:18:32 -0700 (Thu, 15 Jun 2017)

Log Message

[WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
https://bugs.webkit.org/show_bug.cgi?id=173399

Patch by Fujii Hironori <hironori.fu...@sony.com> on 2017-06-15
Reviewed by Per Arne Vollan.

OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
Curl port needs to do nothing because libcurl doesn't have disk cache.

* DumpRenderTree/win/DumpRenderTree.cpp:
(prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (218319 => 218320)


--- trunk/Tools/ChangeLog	2017-06-15 07:02:38 UTC (rev 218319)
+++ trunk/Tools/ChangeLog	2017-06-15 07:18:32 UTC (rev 218320)
@@ -1,3 +1,17 @@
+2017-06-15  Fujii Hironori  <hironori.fu...@sony.com>
+
+        [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
+        https://bugs.webkit.org/show_bug.cgi?id=173399
+
+        Reviewed by Per Arne Vollan.
+
+        OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
+        Curl port needs to do nothing because libcurl doesn't have disk cache.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
+        CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
+
 2017-06-14  Tomas Popela  <tpop...@redhat.com>
 
         [GTK] integer _expression_ expected if running Tools/gtk/install-dependencies

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (218319 => 218320)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-06-15 07:02:38 UTC (rev 218319)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-06-15 07:18:32 UTC (rev 218320)
@@ -1466,8 +1466,10 @@
     ASSERT(standardPreferencesPrivate);
     standardPreferences->setAutosaves(FALSE);
 
+#if USE(CFURLCONNECTION)
     auto newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr));
     CFURLCacheSetSharedURLCache(newCache.get());
+#endif
 
     COMPtr<IWebPreferencesPrivate4> prefsPrivate4(Query, standardPreferences);
     prefsPrivate4->switchNetworkLoaderToNewTestingSession();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to